diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2020-12-08 03:40:25 +0200 |
|---|---|---|
| committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2020-12-09 11:26:13 +0200 |
| commit | ff2ee0174ca62ab4460adfe20049ed05f52615c5 (patch) | |
| tree | 292907ad2f2cc3252d9027822a7024dce6a59021 /src/libcamera/pipeline/rkisp1/rkisp1_path.h | |
| parent | 2795f333fce5f43a4239d8d40d34dde4e5caa6ca (diff) | |
libcamera: v4l2_subdevice: Return a unique pointer from fromEntityName()
The fromEntityName() function returns a pointer to a newly allocated
V4L2Subdevice instance, which must be deleted by the caller. This opens
the door to memory leaks. Return a unique pointer instead, which conveys
the API semantics better than a sentence in the documentation.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Diffstat (limited to 'src/libcamera/pipeline/rkisp1/rkisp1_path.h')
| -rw-r--r-- | src/libcamera/pipeline/rkisp1/rkisp1_path.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h index 8f443e51..f06ac5a7 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h @@ -7,6 +7,7 @@ #ifndef __LIBCAMERA_PIPELINE_RKISP1_PATH_H__ #define __LIBCAMERA_PIPELINE_RKISP1_PATH_H__ +#include <memory> #include <vector> #include <libcamera/camera.h> @@ -65,7 +66,7 @@ private: const Size minResolution_; const Size maxResolution_; - V4L2Subdevice *resizer_; + std::unique_ptr<V4L2Subdevice> resizer_; V4L2VideoDevice *video_; MediaLink *link_; }; |