From ff2ee0174ca62ab4460adfe20049ed05f52615c5 Mon Sep 17 00:00:00 2001
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Tue, 8 Dec 2020 03:40:25 +0200
Subject: libcamera: v4l2_subdevice: Return a unique pointer from
 fromEntityName()

The fromEntityName() function returns a pointer to a newly allocated
V4L2Subdevice instance, which must be deleted by the caller. This opens
the door to memory leaks. Return a unique pointer instead, which conveys
the API semantics better than a sentence in the documentation.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/pipeline/rkisp1/rkisp1_path.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'src/libcamera/pipeline/rkisp1/rkisp1_path.h')

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.h b/src/libcamera/pipeline/rkisp1/rkisp1_path.h
index 8f443e51..f06ac5a7 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.h
+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.h
@@ -7,6 +7,7 @@
 #ifndef __LIBCAMERA_PIPELINE_RKISP1_PATH_H__
 #define __LIBCAMERA_PIPELINE_RKISP1_PATH_H__
 
+#include <memory>
 #include <vector>
 
 #include <libcamera/camera.h>
@@ -65,7 +66,7 @@ private:
 	const Size minResolution_;
 	const Size maxResolution_;
 
-	V4L2Subdevice *resizer_;
+	std::unique_ptr<V4L2Subdevice> resizer_;
 	V4L2VideoDevice *video_;
 	MediaLink *link_;
 };
-- 
cgit v1.2.1