summaryrefslogtreecommitdiff
path: root/src/ipa
diff options
context:
space:
mode:
authorNaushir Patuck <naush@raspberrypi.com>2025-06-06 11:55:24 +0100
committerKieran Bingham <kieran.bingham@ideasonboard.com>2025-06-12 17:26:55 +0100
commit8d2cd0b5b813bf5d26918df2218f2c0493992de6 (patch)
tree8c819f4d7facad2f84c8126338bafb78d04350b7 /src/ipa
parenta402f9ebc1225b684300fcc664fd37e0ddf95f30 (diff)
ipa: rpi: Rename dropFrameCount_ to invalidCount_HEADmaster
Rename dropFrameCount_ to invalidCount_ to better reflect its use as frames are no longer dropped by the pipeline handler. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/ipa')
-rw-r--r--src/ipa/rpi/common/ipa_base.cpp10
-rw-r--r--src/ipa/rpi/common/ipa_base.h4
2 files changed, 7 insertions, 7 deletions
diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp
index eee81e06..50e25f05 100644
--- a/src/ipa/rpi/common/ipa_base.cpp
+++ b/src/ipa/rpi/common/ipa_base.cpp
@@ -327,7 +327,7 @@ void IpaBase::start(const ControlList &controls, StartResult *result)
unsigned int agcConvergenceFrames = 0, awbConvergenceFrames = 0;
frameCount_ = 0;
if (firstStart_) {
- dropFrameCount_ = helper_->hideFramesStartup();
+ invalidCount_ = helper_->hideFramesStartup();
mistrustCount_ = helper_->mistrustFramesStartup();
/*
@@ -353,14 +353,14 @@ void IpaBase::start(const ControlList &controls, StartResult *result)
awbConvergenceFrames += mistrustCount_;
}
} else {
- dropFrameCount_ = helper_->hideFramesModeSwitch();
+ invalidCount_ = helper_->hideFramesModeSwitch();
mistrustCount_ = helper_->mistrustFramesModeSwitch();
}
result->startupFrameCount = std::max({ agcConvergenceFrames, awbConvergenceFrames });
- result->invalidFrameCount = dropFrameCount_;
+ result->invalidFrameCount = invalidCount_;
- dropFrameCount_ = std::max({ dropFrameCount_, agcConvergenceFrames, awbConvergenceFrames });
+ invalidCount_ = std::max({ invalidCount_, agcConvergenceFrames, awbConvergenceFrames });
LOG(IPARPI, Debug) << "Startup frames: " << result->startupFrameCount
<< " Invalid frames: " << result->invalidFrameCount;
@@ -443,7 +443,7 @@ void IpaBase::prepareIsp(const PrepareParams &params)
/* Allow a 10% margin on the comparison below. */
Duration delta = (frameTimestamp - lastRunTimestamp_) * 1.0ns;
- if (lastRunTimestamp_ && frameCount_ > dropFrameCount_ &&
+ if (lastRunTimestamp_ && frameCount_ > invalidCount_ &&
delta < controllerMinFrameDuration * 0.9 && !hdrChange) {
/*
* Ensure we merge the previous frame's metadata with the current
diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h
index 1a811beb..e818104b 100644
--- a/src/ipa/rpi/common/ipa_base.h
+++ b/src/ipa/rpi/common/ipa_base.h
@@ -115,8 +115,8 @@ private:
/* How many frames we should avoid running control algos on. */
unsigned int mistrustCount_;
- /* Number of frames that need to be dropped on startup. */
- unsigned int dropFrameCount_;
+ /* Number of frames that need to be marked as dropped on startup. */
+ unsigned int invalidCount_;
/* Frame timestamp for the last run of the controller. */
uint64_t lastRunTimestamp_;