diff options
| author | Barnabás Pőcze <barnabas.pocze@ideasonboard.com> | 2025-03-19 16:36:36 +0100 |
|---|---|---|
| committer | Barnabás Pőcze <barnabas.pocze@ideasonboard.com> | 2025-04-01 12:58:45 +0200 |
| commit | 7dd548f678bfcac435ae0f790c33f99b6fb2c5c4 (patch) | |
| tree | 449325881d1a88483506693d5afd493d7f22bf20 /include | |
| parent | 37283b68eacbcb0a234c1bd21eedaa22323240b8 (diff) | |
libcamera: base: object: Forward arguments when invoking
Use `std::forward()` to forward the received arguments to enable the
potential use of move constructors instead of copy constructors.
Commit 0eacde623bb0 ("libcamera: object: Avoid argument copies in invokeMethod()")
added the forwarding references to `invokeMethod()` but it did not add the
appropriate `std::forward()` calls, so copying could still take place
even if not necessary.
Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/libcamera/base/object.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/libcamera/base/object.h b/include/libcamera/base/object.h index 6cb935a0..a24f84ff 100644 --- a/include/libcamera/base/object.h +++ b/include/libcamera/base/object.h @@ -9,6 +9,7 @@ #include <list> #include <memory> +#include <utility> #include <vector> #include <libcamera/base/bound_method.h> @@ -39,7 +40,7 @@ public: { T *obj = static_cast<T *>(this); auto *method = new BoundMethodMember<T, R, FuncArgs...>(obj, this, func, type); - return method->activate(args..., true); + return method->activate(std::forward<Args>(args)..., true); } Thread *thread() const { return thread_; } |