From 7dd548f678bfcac435ae0f790c33f99b6fb2c5c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Wed, 19 Mar 2025 16:36:36 +0100 Subject: libcamera: base: object: Forward arguments when invoking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use `std::forward()` to forward the received arguments to enable the potential use of move constructors instead of copy constructors. Commit 0eacde623bb0 ("libcamera: object: Avoid argument copies in invokeMethod()") added the forwarding references to `invokeMethod()` but it did not add the appropriate `std::forward()` calls, so copying could still take place even if not necessary. Signed-off-by: Barnabás Pőcze Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- include/libcamera/base/object.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'include') diff --git a/include/libcamera/base/object.h b/include/libcamera/base/object.h index 6cb935a0..a24f84ff 100644 --- a/include/libcamera/base/object.h +++ b/include/libcamera/base/object.h @@ -9,6 +9,7 @@ #include #include +#include #include #include @@ -39,7 +40,7 @@ public: { T *obj = static_cast(this); auto *method = new BoundMethodMember(obj, this, func, type); - return method->activate(args..., true); + return method->activate(std::forward(args)..., true); } Thread *thread() const { return thread_; } -- cgit v1.2.1