diff options
| author | Jacopo Mondi <jacopo@jmondi.org> | 2021-04-21 17:20:00 +0200 |
|---|---|---|
| committer | Jacopo Mondi <jacopo@jmondi.org> | 2021-05-06 15:08:34 +0200 |
| commit | f3481886255675a6ba1342865bf8fd0033a30eba (patch) | |
| tree | 8381156e6ad0098965c14a1a3685b5bf0213b96e | |
| parent | a5c881645a855d26b0b1fd7746212aa9f6beddb4 (diff) | |
test: control_list: Check for Brightness presence
The current test verifies that after adding a new control to a list
already populated with one control the new one is present.
However the test wrongly tests for its presence twice instead of
making sure the existing control is still there.
Fix this by checking for the presence of both controls after the
update, and fix the error message accordingly.
Fixes: a8c40942b99e ("libcamera: controls: Improve the API towards applications")
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
| -rw-r--r-- | test/controls/control_list.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/test/controls/control_list.cpp b/test/controls/control_list.cpp index b5a49dc1..2b321ddd 100644 --- a/test/controls/control_list.cpp +++ b/test/controls/control_list.cpp @@ -108,9 +108,10 @@ protected: list.set(controls::Brightness, 0.0f); list.set(controls::Contrast, 1.5f); - if (!list.contains(controls::Contrast) || + if (!list.contains(controls::Brightness) || !list.contains(controls::Contrast)) { - cout << "List should contain Contrast control" << endl; + cout << "List should contain Brightness and Contrast controls" + << endl; return TestFail; } |