summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo.mondi@ideasonboard.com>2024-10-28 10:32:00 +0100
committerJacopo Mondi <jacopo.mondi@ideasonboard.com>2024-11-05 18:14:06 +0100
commite1d45a17f76d5d125d44409b259114b087a4bfe3 (patch)
treef3fb4559eb79fc8f742aee91dbe2609d1ad2bb5c
parent5cb45181d7a6379d7eb3717f2ca8f0ab799baa1f (diff)
libcamera: rkisp1: Create main buffer pool out of if(!isRaw)
The "useDewarper_" class variable is set to true during configure only if the configuration is !isRaw. The main path buffer pool creation can thus be moved out of the if (!isRaw) block at allocateBuffers() time. Cosmetic change that will make it easier to create a buffer pool for the main and self paths unconditionally in future. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
-rw-r--r--src/libcamera/pipeline/rkisp1/rkisp1.cpp16
1 files changed, 8 insertions, 8 deletions
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 870ddf8a..d70b46e5 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -927,16 +927,16 @@ int PipelineHandlerRkISP1::allocateBuffers(Camera *camera)
ret = stat_->allocateBuffers(maxCount, &statBuffers_);
if (ret < 0)
goto error;
+ }
- /* If the dewarper is being used, allocate internal buffers for ISP. */
- if (useDewarper_) {
- ret = mainPath_.exportBuffers(maxCount, &mainPathBuffers_);
- if (ret < 0)
- goto error;
+ /* If the dewarper is being used, allocate internal buffers for ISP. */
+ if (useDewarper_) {
+ ret = mainPath_.exportBuffers(maxCount, &mainPathBuffers_);
+ if (ret < 0)
+ goto error;
- for (std::unique_ptr<FrameBuffer> &buffer : mainPathBuffers_)
- availableMainPathBuffers_.push(buffer.get());
- }
+ for (std::unique_ptr<FrameBuffer> &buffer : mainPathBuffers_)
+ availableMainPathBuffers_.push(buffer.get());
}
for (std::unique_ptr<FrameBuffer> &buffer : paramBuffers_) {