summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-05-18 16:35:10 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-05-19 18:08:27 +0300
commitdfa25e18334c9dc68b1939c62d6b711ece153f92 (patch)
tree081b722167db24a2973971504c084b0d6f3b9347
parentc7463138c666d826de26969bf03819936a8cf664 (diff)
libcamera: v4l2_videodevice: Use FileDescriptor "fd move" constructor
Use the newly added "fd move" constructor of the FileDescriptor class to avoid dup() + close(). Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Naushir Patuck <naush@raspberrypi.com>
-rw-r--r--src/libcamera/v4l2_videodevice.cpp9
1 files changed, 1 insertions, 8 deletions
diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
index fbe55bc6..3614b2ed 100644
--- a/src/libcamera/v4l2_videodevice.cpp
+++ b/src/libcamera/v4l2_videodevice.cpp
@@ -1276,14 +1276,7 @@ FileDescriptor V4L2VideoDevice::exportDmabufFd(unsigned int index,
return FileDescriptor();
}
- FileDescriptor fd(expbuf.fd);
- /*
- * FileDescriptor takes a duplicate of fd, so we must close the
- * original here, otherwise it will be left dangling.
- */
- ::close(expbuf.fd);
-
- return fd;
+ return FileDescriptor(std::move(expbuf.fd));
}
/**