diff options
| author | Niklas Söderlund <niklas.soderlund@ragnatech.se> | 2020-06-27 01:19:21 +0200 |
|---|---|---|
| committer | Niklas Söderlund <niklas.soderlund@ragnatech.se> | 2020-06-28 14:25:46 +0200 |
| commit | d275243979ceefea5c347fa532617cc3648f6582 (patch) | |
| tree | 455061297c4adce2a1c1648429f0638c4a4c3a61 | |
| parent | 2ea9d2c1d04834c35c42ecd8b03fc870d3442873 (diff) | |
libcamera: ipu3: imgu: Mark things that are internal as private
Mark all variables and functions that are only used internally as
private.
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
| -rw-r--r-- | src/libcamera/pipeline/ipu3/imgu.h | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h index 82222e0a..31f4d75c 100644 --- a/src/libcamera/pipeline/ipu3/imgu.h +++ b/src/libcamera/pipeline/ipu3/imgu.h @@ -22,11 +22,6 @@ struct StreamConfiguration; class ImgUDevice { public: - static constexpr unsigned int PAD_INPUT = 0; - static constexpr unsigned int PAD_OUTPUT = 2; - static constexpr unsigned int PAD_VF = 3; - static constexpr unsigned int PAD_STAT = 4; - /* ImgU output descriptor: group data specific to an ImgU output. */ struct ImgUOutput { V4L2VideoDevice *dev; @@ -62,20 +57,27 @@ public: int start(); int stop(); - int linkSetup(const std::string &source, unsigned int sourcePad, - const std::string &sink, unsigned int sinkPad, - bool enable); int enableLinks(bool enable); - std::string name_; - MediaDevice *media_; - V4L2Subdevice *imgu_; V4L2VideoDevice *input_; ImgUOutput output_; ImgUOutput viewfinder_; ImgUOutput stat_; /* \todo Add param video device for 3A tuning */ + +private: + static constexpr unsigned int PAD_INPUT = 0; + static constexpr unsigned int PAD_OUTPUT = 2; + static constexpr unsigned int PAD_VF = 3; + static constexpr unsigned int PAD_STAT = 4; + + int linkSetup(const std::string &source, unsigned int sourcePad, + const std::string &sink, unsigned int sinkPad, + bool enable); + + std::string name_; + MediaDevice *media_; }; } /* namespace libcamera */ |