summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNiklas Söderlund <niklas.soderlund@ragnatech.se>2020-10-28 02:15:46 +0100
committerNiklas Söderlund <niklas.soderlund@ragnatech.se>2020-10-28 15:49:21 +0100
commitbfd588d1d8332453b5f7afc6749fc6f3bf00c0bd (patch)
tree6089b392e2f5ec9a1de83650cf1804b5390a8479
parentb86356feee1cbdb7c64f1bee830aaa54c1b38af0 (diff)
libcamera: v4l2_device: Remove unused set of ret
The last assignment of the ret variable in getControls() is not consumed so it's unnecessary to set it. This likely originates from a similar code flow in setControls() where the ret variable is later consumed. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rw-r--r--src/libcamera/v4l2_device.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp
index 31d4dad0..f747ba79 100644
--- a/src/libcamera/v4l2_device.cpp
+++ b/src/libcamera/v4l2_device.cpp
@@ -243,7 +243,6 @@ ControlList V4L2Device::getControls(const std::vector<uint32_t> &ids)
LOG(V4L2, Error) << "Unable to read control " << errorIdx
<< ": " << strerror(-ret);
count = errorIdx - 1;
- ret = errorIdx;
}
updateControls(&ctrls, v4l2Ctrls, count);