summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNiklas Söderlund <niklas.soderlund@ragnatech.se>2019-10-27 04:49:58 +0100
committerNiklas Söderlund <niklas.soderlund@ragnatech.se>2019-11-20 00:36:27 +0100
commitbcf42994530a0112ac250a1640562edc16353299 (patch)
tree6576e18085d77b6fc97d338d91071a3c546b66d6
parentc360857c5d57e21772af015477da305817b16bbb (diff)
libcamera: pipeline_handler: Do not use argument as local variable
In completeRequest() the request argument is used as a local variable, this is confusing. Add a separate local variable instead of reusing the argument. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-rw-r--r--src/libcamera/pipeline_handler.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp
index 884feaa6..4349ca89 100644
--- a/src/libcamera/pipeline_handler.cpp
+++ b/src/libcamera/pipeline_handler.cpp
@@ -409,13 +409,13 @@ void PipelineHandler::completeRequest(Camera *camera, Request *request)
CameraData *data = cameraData(camera);
while (!data->queuedRequests_.empty()) {
- request = data->queuedRequests_.front();
- if (request->status() == Request::RequestPending)
+ Request *req = data->queuedRequests_.front();
+ if (req->status() == Request::RequestPending)
break;
- ASSERT(!request->hasPendingBuffers());
+ ASSERT(!req->hasPendingBuffers());
data->queuedRequests_.pop_front();
- camera->requestComplete(request);
+ camera->requestComplete(req);
}
}