diff options
| author | Umang Jain <umang.jain@ideasonboard.com> | 2024-10-11 14:52:21 +0530 |
|---|---|---|
| committer | Umang Jain <umang.jain@ideasonboard.com> | 2024-10-15 10:31:47 +0530 |
| commit | a2be725d2652ba71d23adf36bb8a1342947debbf (patch) | |
| tree | 2cd50dc87c83b4a46426087f6da2f958a8d50e95 | |
| parent | 326e0aa834487dd50610c0ff0423acc48d7b2298 (diff) | |
libcamera: rkisp1: Rectify SensorConfiguration check
The 'found' flag was mistakenly understood that a compatible sensor
format has been found when a sensor configuration is passed in. However,
'found' related to the stream configuration's pixelformat, whether it is
supported by the RkISP1Path video node or not. It does not relate to the
sensor format, hence the check:
if (sensorConfig && !found)
doesn't make sense.
Rectify the above check with:
if (sensorConfig && !rawFormat.isValid())
to ensure a sensor format compatible with sensor configuration has been
set to rawFormat.
Fixes: 047d647452c4 ("libcamera: rkisp1: Integrate SensorConfiguration support")
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
| -rw-r--r-- | src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp index 4a3b779c..236d05af 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp @@ -304,7 +304,7 @@ RkISP1Path::validate(const CameraSensor *sensor, } } - if (sensorConfig && !found) + if (sensorConfig && !rawFormat.isValid()) return CameraConfiguration::Invalid; bool isRaw = PixelFormatInfo::info(cfg->pixelFormat).colourEncoding == |