summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNiklas Söderlund <niklas.soderlund@ragnatech.se>2020-06-29 18:29:56 +0200
committerNiklas Söderlund <niklas.soderlund@ragnatech.se>2020-07-03 00:08:31 +0200
commit8e137b08194ea73c63832750af5ad2930688aa8a (patch)
tree4e39da5696a0a68999ce7aaf1b0525f9e1f20eb0
parent8dbd0049e0f96d9af1c37d88cba523b2fef55bbc (diff)
libcamera: raspberrypi: Document vc_sm_cma pointer sharing with IPA
Sharing a pointer with the IPA is fragile as it will not work with all IPC mechanisms. Document that it's a temporary workaround that should be reworked. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-rw-r--r--src/libcamera/pipeline/raspberrypi/raspberrypi.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
index 9d887b70..f4966f86 100644
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
@@ -1014,6 +1014,11 @@ int PipelineHandlerRPi::configureIPA(Camera *camera)
/*
* The vcsm allocation will always be in the memory region
* < 32-bits to allow Videocore to access the memory.
+ *
+ * \todo Sending a pointer to the IPA is a workaround for
+ * vc_sm_cma not yet supporting dmabuf. This will not work with
+ * IPA module isolation and should be reworked when vc_sma_cma
+ * will permit.
*/
IPAOperationData op;
op.operation = RPI_IPA_EVENT_LS_TABLE_ALLOCATION;