summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-10-15 16:57:34 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-10-15 22:33:26 +0300
commit876b90086215ce933ceb7f2822ba9a9688e07c14 (patch)
treee657faf1333fc321d9a7d4ba7c094479765b04f1
parentf391048a7b987a149d0ba5421846b9b5ab916338 (diff)
libcamera: v4l2_device: Print control ID in unknown type log messagge
When the type of a control enumerated from a V4L2 device is not supported, we log a debug message that mentions the control type. This makes it hard to figure out which control is faulty. Print the control ID instead. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
-rw-r--r--src/libcamera/v4l2_device.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp
index b47ba448..68f2d44d 100644
--- a/src/libcamera/v4l2_device.cpp
+++ b/src/libcamera/v4l2_device.cpp
@@ -8,11 +8,13 @@
#include "v4l2_device.h"
#include <fcntl.h>
+#include <iomanip>
#include <string.h>
#include <sys/ioctl.h>
#include <unistd.h>
#include "log.h"
+#include "utils.h"
#include "v4l2_controls.h"
/**
@@ -371,8 +373,9 @@ void V4L2Device::listControls()
break;
/* \todo Support compound controls. */
default:
- LOG(V4L2, Debug) << "Control type '" << ctrl.type
- << "' not supported";
+ LOG(V4L2, Debug)
+ << "Control " << utils::hex(ctrl.id)
+ << " has unsupported type " << ctrl.type;
continue;
}