summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHelen Koike <helen.koike@collabora.com>2021-02-03 11:29:55 -0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-02-04 01:45:44 +0200
commit5b568b7e41e394b5317057312d07ff71b4d571f7 (patch)
treeba79bb836cda9e1fd1f86e8b64135908641d7ed0
parentfb9051ff7407d6e1abcfafb40a951f55c38dafe9 (diff)
libcamera: v4l2_videodevice: remove confusing memory MMAP assignment before QUERYBUF
QUERYBUF doesn't require the memory field to be pre-filled. Also, V4L2VideoDevice::createBuffer uses dmabuf file descriptors, thus using V4L2_MEMORY_MMAP makes things confusing, so remove it. Signed-off-by: Helen Koike <helen.koike@collabora.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-rw-r--r--src/libcamera/v4l2_videodevice.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp
index a9509bff..c77e1aff 100644
--- a/src/libcamera/v4l2_videodevice.cpp
+++ b/src/libcamera/v4l2_videodevice.cpp
@@ -1255,7 +1255,6 @@ std::unique_ptr<FrameBuffer> V4L2VideoDevice::createBuffer(unsigned int index)
buf.index = index;
buf.type = bufferType_;
- buf.memory = V4L2_MEMORY_MMAP;
buf.length = std::size(v4l2Planes);
buf.m.planes = v4l2Planes;