summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNiklas Söderlund <niklas.soderlund@ragnatech.se>2021-04-13 23:46:45 +0200
committerNiklas Söderlund <niklas.soderlund@ragnatech.se>2021-04-14 16:13:18 +0200
commit58f558fddaf3d7d149ab1c320c2cee7c6948ec01 (patch)
treecd28f5842763886dcdc4950e641ced18db5640b3
parent6c96861ea36f0596fbf4440e457d9366e6855d19 (diff)
lc-compliance: Drop return value from SimpleCapture::stop()
The return value is never checked and serves to real usage, drop it. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-rw-r--r--src/lc-compliance/simple_capture.cpp4
-rw-r--r--src/lc-compliance/simple_capture.h2
2 files changed, 2 insertions, 4 deletions
diff --git a/src/lc-compliance/simple_capture.cpp b/src/lc-compliance/simple_capture.cpp
index 8f714d3b..811a6220 100644
--- a/src/lc-compliance/simple_capture.cpp
+++ b/src/lc-compliance/simple_capture.cpp
@@ -50,7 +50,7 @@ Results::Result SimpleCapture::start()
return { Results::Pass, "Started camera" };
}
-Results::Result SimpleCapture::stop()
+void SimpleCapture::stop()
{
Stream *stream = config_->at(0).stream();
@@ -59,8 +59,6 @@ Results::Result SimpleCapture::stop()
camera_->requestCompleted.disconnect(this, &SimpleCapture::requestComplete);
allocator_->free(stream);
-
- return { Results::Pass, "Stopped camera" };
}
/* SimpleCaptureBalanced */
diff --git a/src/lc-compliance/simple_capture.h b/src/lc-compliance/simple_capture.h
index 4693c134..d9de53fb 100644
--- a/src/lc-compliance/simple_capture.h
+++ b/src/lc-compliance/simple_capture.h
@@ -24,7 +24,7 @@ protected:
virtual ~SimpleCapture();
Results::Result start();
- Results::Result stop();
+ void stop();
virtual void requestComplete(libcamera::Request *request) = 0;