diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2025-05-22 14:38:00 +0200 |
|---|---|---|
| committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2025-05-22 19:04:15 +0200 |
| commit | 516f365670235f9dac97defa1b586d0503f8e310 (patch) | |
| tree | 7463654396911776799153bf75d5293b58f6f86b | |
| parent | d997e97512908f3047d4bbc481590d4a1475ce1e (diff) | |
libcamera: matrix: Fix compilation error in inverse() function
Some gcc versions report uninitialized variable usage:
In member function ‘constexpr T& libcamera::Span<T, 4294967295>::operator[](size_type) const [with T = unsigned int]’,
inlined from ‘void libcamera::matrixInvert(Span<const T>, Span<T, 4294967295>, unsigned int, Span<T, 4294967295>, Span<unsigned int>)::MatrixAccessor::swap(unsigned int, unsigned int) [with T = float]’ at ../../src/libcamera/matrix.cpp:194:13,
inlined from ‘bool libcamera::matrixInvert(Span<const T>, Span<T, 4294967295>, unsigned int, Span<T, 4294967295>, Span<unsigned int>) [with T = float]’ at ../../src/libcamera/matrix.cpp:255:14:
../../include/libcamera/base/span.h:362:76: error: ‘row’ may be used uninitialized [-Werror=maybe-uninitialized]
362 | constexpr reference operator[](size_type idx) const { return data()[idx]; }
| ~~~~~~^
../../src/libcamera/matrix.cpp: In function ‘bool libcamera::matrixInvert(Span<const T>, Span<T, 4294967295>, unsigned int, Span<T, 4294967295>, Span<unsigned int>) [with T = float]’:
../../src/libcamera/matrix.cpp:232:30: note: ‘row’ was declared here
232 | unsigned int row;
| ^~~
This is a false positive. Fix it by initializing the variable when
declaring it.
Fixes: 6287ceff5aba ("libcamera: matrix: Add inverse() function")
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Tested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Tested-by: Milan Zamazal <mzamazal@redhat.com>
| -rw-r--r-- | src/libcamera/matrix.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libcamera/matrix.cpp b/src/libcamera/matrix.cpp index ed22263b..b7c07e89 100644 --- a/src/libcamera/matrix.cpp +++ b/src/libcamera/matrix.cpp @@ -229,7 +229,7 @@ bool matrixInvert(Span<const T> dataIn, Span<T> dataOut, unsigned int dim, * Locate the next pivot. To improve numerical stability, use * the row with the largest value in the pivot's column. */ - unsigned int row; + unsigned int row = pivot; T maxValue{ 0 }; for (unsigned int i = pivot; i < dim; ++i) { |