summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-10-30 03:35:32 +0200
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-11-02 01:03:31 +0200
commit4757ff4ab7b4dac560cad26db12e28ef741c96ff (patch)
tree014c56d80f229124291c61f76aa31116d0371d3e
parent58d487b10e06ad823103957c1e6aa2201720fdae (diff)
utils: hooks: pre-push: Reject commits with a Change-Id
We're not using gerrit, so let's prevent Change-Id tags creeping in unadvertently. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rwxr-xr-xutils/hooks/pre-push7
1 files changed, 7 insertions, 0 deletions
diff --git a/utils/hooks/pre-push b/utils/hooks/pre-push
index 2417d379..d13e2c3b 100755
--- a/utils/hooks/pre-push
+++ b/utils/hooks/pre-push
@@ -63,6 +63,13 @@ do
echo >&2 "No Reviewed-by or Acked-by in commit $commit"
errors=$((errors+1))
fi
+
+ # 4. The commit message shall not contain a Change-Id.
+ if echo "$msg" | grep -q '^Change-Id:'
+ then
+ echo >&2 "Found Change-Id in commit $commit"
+ errors=$((errors+1))
+ fi
done
if [ $errors != 0 ]