summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-05-09 02:18:52 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-06-17 15:04:02 +0300
commit3faa04fe48b394e0c73056183293a5b77116e539 (patch)
tree4f13450d91e7a356d9caa7bbafed4104a91e5f68
parent8fd673deaf9beb2e9be9c81342f728c2b7b0513a (diff)
ipa: libipa: agc_mean_luminance: Fix enumerator names
Enumerators in libcamera start with an upper case letter. Fix the AgcConstraint::Bound enumerators. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
-rw-r--r--src/ipa/libipa/agc_mean_luminance.cpp10
-rw-r--r--src/ipa/libipa/agc_mean_luminance.h4
2 files changed, 7 insertions, 7 deletions
diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp
index 271b5ae4..f97ef117 100644
--- a/src/ipa/libipa/agc_mean_luminance.cpp
+++ b/src/ipa/libipa/agc_mean_luminance.cpp
@@ -59,9 +59,9 @@ static constexpr double kDefaultRelativeLuminanceTarget = 0.16;
/**
* \enum AgcMeanLuminance::AgcConstraint::Bound
* \brief Specify whether the constraint defines a lower or upper bound
- * \var AgcMeanLuminance::AgcConstraint::lower
+ * \var AgcMeanLuminance::AgcConstraint::Lower
* \brief The constraint defines a lower bound
- * \var AgcMeanLuminance::AgcConstraint::upper
+ * \var AgcMeanLuminance::AgcConstraint::Upper
* \brief The constraint defines an upper bound
*/
@@ -209,7 +209,7 @@ int AgcMeanLuminance::parseConstraintModes(const YamlObject &tuningData)
*/
if (constraintModes_.empty()) {
AgcConstraint constraint = {
- AgcConstraint::Bound::lower,
+ AgcConstraint::Bound::Lower,
0.98,
1.0,
0.5
@@ -467,11 +467,11 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,
double newGain = constraint.yTarget * hist.bins() /
hist.interQuantileMean(constraint.qLo, constraint.qHi);
- if (constraint.bound == AgcConstraint::Bound::lower &&
+ if (constraint.bound == AgcConstraint::Bound::Lower &&
newGain > gain)
gain = newGain;
- if (constraint.bound == AgcConstraint::Bound::upper &&
+ if (constraint.bound == AgcConstraint::Bound::Upper &&
newGain < gain)
gain = newGain;
}
diff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h
index 0a81c6d2..d1bddda5 100644
--- a/src/ipa/libipa/agc_mean_luminance.h
+++ b/src/ipa/libipa/agc_mean_luminance.h
@@ -31,8 +31,8 @@ public:
struct AgcConstraint {
enum class Bound {
- lower = 0,
- upper = 1
+ Lower = 0,
+ Upper = 1
};
Bound bound;
double qLo;