summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-04-26 19:05:33 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-04-26 19:26:56 +0300
commit2ab299a27686776d45699c7cea6ba9ce4af6d514 (patch)
tree53550f6b603208779f1c1fdda09b222b47b4a0d4
parent4c8989cdf7b7fcf1c6e84c2688584c2a7394ea18 (diff)
libcamera: Remove outdated \todo comments
Some \todo comments are outdated and refer to tasks that have been completed. Remove them. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
-rw-r--r--src/libcamera/camera_manager.cpp3
-rw-r--r--src/libcamera/device_enumerator.cpp1
-rw-r--r--src/libcamera/v4l2_device.cpp6
3 files changed, 2 insertions, 8 deletions
diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp
index 58d3b0dd..40a39bd2 100644
--- a/src/libcamera/camera_manager.cpp
+++ b/src/libcamera/camera_manager.cpp
@@ -50,9 +50,6 @@ LOG_DEFINE_CATEGORY(Camera)
* references it held to cameras, the camera manager can be stopped with
* stop().
*
- * \todo Add ability to add and remove media devices based on hot-(un)plug
- * events coming from the device enumerator.
- *
* \todo Add interface to register a notification callback to the user to be
* able to inform it new cameras have been hot-plugged or cameras have been
* removed due to hot-unplug.
diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp
index f3f26d98..49467546 100644
--- a/src/libcamera/device_enumerator.cpp
+++ b/src/libcamera/device_enumerator.cpp
@@ -40,7 +40,6 @@
* expressed in a DeviceMatch object.
*
* \todo Add sysfs based device enumerator.
- * \todo Add support for hot-plug and hot-unplug.
*/
namespace libcamera {
diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp
index cfdce481..a6e9ca24 100644
--- a/src/libcamera/v4l2_device.cpp
+++ b/src/libcamera/v4l2_device.cpp
@@ -750,9 +750,6 @@ int V4L2Device::releaseBuffers()
* processed by the device. Once the device has finished processing the buffer,
* it will be available for dequeue.
*
- * \todo Support output devices (bytesused, ...)
- * \todo Support imported buffers (dmabuf fd)
- *
* \return 0 on success or a negative error code otherwise
*/
int V4L2Device::queueBuffer(Buffer *buffer)
@@ -904,7 +901,8 @@ int V4L2Device::streamOn()
/**
* \brief Stop the video stream
*
- * \todo Ensure completion notifications are sent for all queued buffers
+ * Buffers that are still queued when the video stream is stopped are
+ * implicitly dequeued, but no bufferReady signal is emitted for them.
*
* \return 0 on success or a negative error code otherwise
*/