summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo@jmondi.org>2020-12-18 15:58:10 +0100
committerJacopo Mondi <jacopo@jmondi.org>2020-12-30 11:22:52 +0100
commit0a0264da8d6d845b743fdf7ad1092aa26eccc547 (patch)
tree58ff4046446621cf951630b7a236eafc33bfa185
parent1c0096d7517afca568e642dac6ffce894a5098fb (diff)
libcamera: camera_sensor: Register ColorFilterArrangement
Inspect the list of media bus codes supported by the camera sensor in order to deduce the color filter arrangement and register the ColorFilterArrangement draft property. Reviewed-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
-rw-r--r--src/libcamera/camera_sensor.cpp36
1 files changed, 32 insertions, 4 deletions
diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
index 1628ba9c..e786821d 100644
--- a/src/libcamera/camera_sensor.cpp
+++ b/src/libcamera/camera_sensor.cpp
@@ -17,6 +17,7 @@
#include <libcamera/property_ids.h>
+#include "libcamera/internal/bayer_format.h"
#include "libcamera/internal/formats.h"
#include "libcamera/internal/sysfs.h"
#include "libcamera/internal/utils.h"
@@ -178,10 +179,6 @@ int CameraSensor::init()
if (ret < 0)
return ret;
- ret = initProperties();
- if (ret)
- return ret;
-
/* Enumerate, sort and cache media bus codes and sizes. */
formats_ = subdev_->formats(pad_);
if (formats_.empty()) {
@@ -210,6 +207,10 @@ int CameraSensor::init()
*/
resolution_ = sizes_.back();
+ ret = initProperties();
+ if (ret)
+ return ret;
+
return 0;
}
@@ -307,6 +308,33 @@ int CameraSensor::initProperties()
properties_.set(properties::PixelArrayActiveAreas, { crop });
}
+ /* Color filter array pattern, register only for RAW sensors. */
+ for (const auto &format : formats_) {
+ unsigned int mbusCode = format.first;
+ BayerFormat bayerFormat = BayerFormat::fromMbusCode(mbusCode);
+ if (!bayerFormat.isValid())
+ continue;
+
+ int32_t cfa;
+ switch (bayerFormat.order) {
+ case BayerFormat::BGGR:
+ cfa = properties::draft::BGGR;
+ break;
+ case BayerFormat::GBRG:
+ cfa = properties::draft::GBRG;
+ break;
+ case BayerFormat::GRBG:
+ cfa = properties::draft::GRBG;
+ break;
+ case BayerFormat::RGGB:
+ cfa = properties::draft::RGGB;
+ break;
+ }
+
+ properties_.set(properties::draft::ColorFilterArrangement, cfa);
+ break;
+ }
+
return 0;
}