summaryrefslogtreecommitdiff
path: root/test/camera/capture.cpp
diff options
context:
space:
mode:
authorKieran Bingham <kieran.bingham@ideasonboard.com>2023-07-25 13:56:40 +0100
committerKieran Bingham <kieran.bingham@ideasonboard.com>2023-10-16 16:38:08 +0100
commitc258302863da5fe36aba1caa82b27e9154b6c0a2 (patch)
treeebad22ef8094948cd2af2ebfa1feb77990ff2044 /test/camera/capture.cpp
parentd05009d34c67dfb11e890eaee2858a7e99ed06e4 (diff)
py: gen-py-controls: Remove SceneFlicker workaround
The python bindings layer has to parse the libcamera controls to ensure that they are converted to suitable names for the python layer. Part of this strips out common prefixes from control names, however the SceneFlicker control would end up using an illegal name if processed in the same way as the other controls. The SceneFlicker control has now been removed as part of the introduction of the AeFlickerMode and AeFlickerPeriod controls. Remove the workaround in the python layer. Fixes: 6fdbf3f38c31 ("libcamera: controls: Add controls for AEC/AGC flicker avoidance") Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'test/camera/capture.cpp')
0 files changed, 0 insertions, 0 deletions
generated by cgit v1.2.1 (git 2.18.0) at 2024-12-20 16:56:52 +0000
'#n66'>66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 
/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
 * Copyright (C) 2020, Sebastian Fricke
 *
 * BayerFormat class tests
 */

#include <iostream>

#include <libcamera/transform.h>

#include "libcamera/internal/bayer_format.h"

#include "test.h"

using namespace std;
using namespace libcamera;

class BayerFormatTest : public Test
{
protected:
	int run()
	{
		/* An empty Bayer format has to be invalid. */
		BayerFormat bayerFmt;
		if (bayerFmt.isValid()) {
			cerr << "An empty BayerFormat has to be invalid."
			     << endl;
			return TestFail;
		}

		/* A correct Bayer format has to be valid. */
		bayerFmt = BayerFormat(BayerFormat::BGGR, 8, BayerFormat::Packing::None);
		if (!bayerFmt.isValid()) {
			cerr << "A correct BayerFormat has to be valid."
			     << endl;
			return TestFail;
		}

		/*
		 * Two bayer formats created with the same order and bit depth
		 * have to be equal.
		 */
		bayerFmt = BayerFormat(BayerFormat::BGGR, 8, BayerFormat::Packing::None);
		BayerFormat bayerFmtExpect = BayerFormat(BayerFormat::BGGR, 8,
							 BayerFormat::Packing::None);
		if (bayerFmt != bayerFmtExpect) {
			cerr << "Comparison of identical formats failed."
			     << endl;
			return TestFail;
		}

		/*
		 * Two Bayer formats created with the same order but with a
		 * different bitDepth are not equal.
		 */
		bayerFmt = BayerFormat(BayerFormat::BGGR, 8, BayerFormat::Packing::None);
		bayerFmtExpect = BayerFormat(BayerFormat::BGGR, 12,
					     BayerFormat::Packing::None);
		if (bayerFmt == bayerFmtExpect) {
			cerr << "Comparison of different formats failed."
			     << endl;
			return TestFail;
		}

		/*
		 * Create a Bayer format with a V4L2PixelFormat and check if we
		 * get the same format after converting back to the V4L2 Format.
		 */
		V4L2PixelFormat v4l2FmtExpect = V4L2PixelFormat(
			V4L2_PIX_FMT_SBGGR8);
		bayerFmt = BayerFormat::fromV4L2PixelFormat(v4l2FmtExpect);
		V4L2PixelFormat v4l2Fmt = bayerFmt.toV4L2PixelFormat();
		if (v4l2Fmt != v4l2FmtExpect) {
			cerr << "Expected: '" << v4l2FmtExpect
			     << "' got: '" << v4l2Fmt << "'" << endl;
			return TestFail;
		}

		/*
		 * Use an empty Bayer format and verify that no matching
		 * V4L2PixelFormat is found.
		 */
		v4l2FmtExpect = V4L2PixelFormat();
		bayerFmt = BayerFormat();
		v4l2Fmt = bayerFmt.toV4L2PixelFormat();
		if (v4l2Fmt != v4l2FmtExpect) {
			cerr << "Expected: empty V4L2PixelFormat got: '"
			     << v4l2Fmt << "'" << endl;
			return TestFail;
		}

		/*
		 * Check if we get the expected Bayer format BGGR8
		 * when we convert the V4L2PixelFormat (V4L2_PIX_FMT_SBGGR8)
		 * to a Bayer format.
		 */
		bayerFmtExpect = BayerFormat(BayerFormat::BGGR, 8,
					     BayerFormat::Packing::None);
		v4l2Fmt = V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8);
		bayerFmt = BayerFormat::fromV4L2PixelFormat(v4l2Fmt);
		if (bayerFmt != bayerFmtExpect) {
			cerr << "Expected BayerFormat '"
			     << bayerFmtExpect << "', got: '"
			     << bayerFmt << "'" << endl;
			return TestFail;
		}

		/*
		 * Confirm that a V4L2PixelFormat that is not found in
		 * the conversion table, doesn't yield a Bayer format.
		 */
		V4L2PixelFormat v4l2FmtUnknown = V4L2PixelFormat(
			V4L2_PIX_FMT_BGRA444);
		bayerFmt = BayerFormat::fromV4L2PixelFormat(v4l2FmtUnknown);
		if (bayerFmt.isValid()) {
			cerr << "Expected empty BayerFormat got: '"
			     << bayerFmt << "'" << endl;
			return TestFail;
		}

		/*
		 * Test if a valid Bayer format can be converted to a
		 * string representation.
		 */
		bayerFmt = BayerFormat(BayerFormat::BGGR, 8, BayerFormat::Packing::None);
		if (bayerFmt.toString() != "BGGR-8") {
			cerr << "String representation != 'BGGR-8' (got: '"
			     << bayerFmt.toString() << "' ) " << endl;
			return TestFail;
		}

		/*
		 * Determine if an empty Bayer format results in no
		 * string representation.
		 */
		bayerFmt = BayerFormat();
		if (bayerFmt.toString() != "INVALID") {
			cerr << "String representation != 'INVALID' (got: '"
			     << bayerFmt.toString() << "' ) " << endl;
			return TestFail;
		}

		/*
		 * Perform a horizontal Flip and make sure that the
		 * order is adjusted accordingly.
		 */
		bayerFmt = BayerFormat(BayerFormat::BGGR, 8, BayerFormat::Packing::None);
		bayerFmtExpect = BayerFormat(BayerFormat::GBRG, 8,
					     BayerFormat::Packing::None);
		BayerFormat hFlipFmt = bayerFmt.transform(Transform::HFlip);
		if (hFlipFmt != bayerFmtExpect) {
			cerr << "Horizontal flip of 'BGGR-8' should result in '"
			     << bayerFmtExpect << "', got: '"
			     << hFlipFmt << "'" << endl;
			return TestFail;
		}

		/*
		 * Perform a vertical Flip and make sure that
		 * the order is adjusted accordingly.
		 */
		bayerFmt = BayerFormat(BayerFormat::BGGR, 8, BayerFormat::Packing::None);
		bayerFmtExpect = BayerFormat(BayerFormat::GRBG, 8,
					     BayerFormat::Packing::None);
		BayerFormat vFlipFmt = bayerFmt.transform(Transform::VFlip);
		if (vFlipFmt != bayerFmtExpect) {
			cerr << "Vertical flip of 'BGGR-8' should result in '"
			     << bayerFmtExpect << "', got: '"
			     << vFlipFmt << "'" << endl;
			return TestFail;
		}

		/*
		 * Perform a transposition on a pixel order with both green
		 * pixels on the bottom left to top right diagonal and make
		 * sure, that it doesn't change.
		 */
		bayerFmt = BayerFormat(BayerFormat::BGGR, 8, BayerFormat::Packing::None);
		BayerFormat transposeFmt = bayerFmt.transform(
			Transform::Transpose);
		if (transposeFmt != bayerFmt) {
			cerr << "Transpose with both green pixels on the "
			     << "antidiagonal should not change the order "
			     << "(got '" << transposeFmt << "')"
			     << endl;
			return TestFail;
		}

		/*
		 * Perform a transposition on an pixel order with red and blue
		 * on the bottom left to top right diagonal and make sure
		 * that their positions are switched.
		 */
		bayerFmt = BayerFormat(BayerFormat::GBRG, 8, BayerFormat::Packing::None);
		bayerFmtExpect = BayerFormat(BayerFormat::GRBG, 8,
					     BayerFormat::Packing::None);
		transposeFmt = bayerFmt.transform(Transform::Transpose);
		if (transposeFmt != bayerFmtExpect) {
			cerr << "Transpose with the red & blue pixels on the "
			     << "antidiagonal should switch their position "
			     << "(got '" << transposeFmt << "')"
			     << endl;
			return TestFail;
		}

		return TestPass;
	}
};

TEST_REGISTER(BayerFormatTest)
generated by cgit v1.2.1 (git 2.18.0) at 2024-12-20 16:56:52 +0000