summaryrefslogtreecommitdiff
path: root/src/qcam/main.cpp
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-09-08 10:48:46 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-09-16 14:21:28 +0300
commitde20029a582a71a87d99388a62fb63c86e85028a (patch)
tree9bffafeabdb1104444550094fa7cdab06a0f0405 /src/qcam/main.cpp
parent219cbfe76b5a7d9d8206c71aa6115ff8befcff9b (diff)
android: Protect against null callbacks
According to the Android camera HAL C interface documentation, the camera service is supposed to set callbacks after initializing the HAL and calling get_number_of_cameras(), before any other calls to the module. We rely on this behaviour and use callbacks unconditionally, which would lead to a crash if the camera service behaved incorrectly. While the camera service isn't supposed to behave incorrectly, gracefully handling the error when opening cameras isn't costly, and provides better diagnostic than a crash. While at it, removed an unneeded [[maybe_unused]] attribute. Reported-by: Coverity CID=298638 Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Umang Jain <email@uajain.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/qcam/main.cpp')
0 files changed, 0 insertions, 0 deletions
generated by cgit v1.2.1 (git 2.18.0) at 2025-01-06 14:00:44 +0000
#n56'>56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 
/* SPDX-License-Identifier: GPL-2.0-or-later */
/*
 * Copyright (C) 2019, Google Inc.
 *
 * control_value.cpp - ControlValue tests
 */

#include <algorithm>
#include <iostream>

#include <libcamera/controls.h>

#include "test.h"

using namespace std;
using namespace libcamera;

class ControlValueTest : public Test
{
protected:
	int run()
	{
		/*
		 * None type.
		 */
		ControlValue value;
		if (!value.isNone() || value.isArray()) {
			cerr << "Empty value is non-null" << endl;
			return TestFail;
		}

		/*
		 * Bool type.
		 */
		value.set(true);
		if (value.isNone() || value.isArray() ||
		    value.type() != ControlTypeBool) {
			cerr << "Control type mismatch after setting to bool" << endl;
			return TestFail;
		}

		if (value.get<bool>() != true) {
			cerr << "Control value mismatch after setting to bool" << endl;
			return TestFail;
		}

		if (value.toString() != "true") {
			cerr << "Control string mismatch after setting to bool" << endl;
			return TestFail;
		}

		std::array<bool, 2> bools{ true, false };
		value.set(Span<bool>(bools));
		if (value.isNone() || !value.isArray() ||
		    value.type() != ControlTypeBool) {
			cerr << "Control type mismatch after setting to bool array" << endl;
			return TestFail;
		}

		Span<const bool> boolsResult = value.get<Span<const bool>>();
		if (bools.size() != boolsResult.size() ||
		    !std::equal(bools.begin(), bools.end(), boolsResult.begin())) {
			cerr << "Control value mismatch after setting to bool" << endl;
			return TestFail;
		}

		if (value.toString() != "[ true, false ]") {
			cerr << "Control string mismatch after setting to bool array" << endl;
			return TestFail;
		}

		/*
		 * Integer8 type.
		 */
		value.set(static_cast<uint8_t>(42));
		if (value.isNone() || value.isArray() ||
		    value.type() != ControlTypeByte) {
			cerr << "Control type mismatch after setting to uint8_t" << endl;
			return TestFail;
		}

		if (value.get<uint8_t>() != 42) {
			cerr << "Control value mismatch after setting to uint8_t" << endl;
			return TestFail;
		}

		if (value.toString() != "42") {
			cerr << "Control string mismatch after setting to uint8_t" << endl;
			return TestFail;
		}

		std::array<uint8_t, 4> bytes{ 3, 14, 15, 9 };
		value.set(Span<uint8_t>(bytes));
		if (value.isNone() || !value.isArray() ||
		    value.type() != ControlTypeByte) {
			cerr << "Control type mismatch after setting to uint8_t array" << endl;
			return TestFail;
		}

		Span<const uint8_t> int8sResult = value.get<Span<const uint8_t>>();
		if (bytes.size() != int8sResult.size() ||
		    !std::equal(bytes.begin(), bytes.end(), int8sResult.begin())) {
			cerr << "Control value mismatch after setting to uint8_t array" << endl;
			return TestFail;
		}

		if (value.toString() != "[ 3, 14, 15, 9 ]") {
			cerr << "Control string mismatch after setting to uint8_t array" << endl;
			return TestFail;
		}

		/*
		 * Integer32 type.
		 */
		value.set(0x42000000);
		if (value.isNone() || value.isArray() ||
		    value.type() != ControlTypeInteger32) {
			cerr << "Control type mismatch after setting to int32_t" << endl;
			return TestFail;
		}

		if (value.get<int32_t>() != 0x42000000) {
			cerr << "Control value mismatch after setting to int32_t" << endl;
			return TestFail;
		}

		if (value.toString() != "1107296256") {
			cerr << "Control string mismatch after setting to int32_t" << endl;
			return TestFail;
		}

		std::array<int32_t, 4> int32s{ 3, 14, 15, 9 };
		value.set(Span<int32_t>(int32s));
		if (value.isNone() || !value.isArray() ||
		    value.type() != ControlTypeInteger32) {
			cerr << "Control type mismatch after setting to int32_t array" << endl;
			return TestFail;
		}

		Span<const int32_t> int32sResult = value.get<Span<const int32_t>>();
		if (int32s.size() != int32sResult.size() ||
		    !std::equal(int32s.begin(), int32s.end(), int32sResult.begin())) {
			cerr << "Control value mismatch after setting to int32_t array" << endl;
			return TestFail;
		}

		if (value.toString() != "[ 3, 14, 15, 9 ]") {
			cerr << "Control string mismatch after setting to int32_t array" << endl;
			return TestFail;
		}

		/*
		 * Integer64 type.
		 */
		value.set(static_cast<int64_t>(-42));
		if (value.isNone() || value.isArray() ||
		    value.type() != ControlTypeInteger64) {
			cerr << "Control type mismatch after setting to int64_t" << endl;
			return TestFail;
		}

		if (value.get<int64_t>() != -42) {
			cerr << "Control value mismatch after setting to int64_t" << endl;
			return TestFail;
		}

		if (value.toString() != "-42") {
			cerr << "Control string mismatch after setting to int64_t" << endl;
			return TestFail;
		}

		std::array<int64_t, 4> int64s{ 3, 14, 15, 9 };
		value.set(Span<int64_t>(int64s));
		if (value.isNone() || !value.isArray() ||
		    value.type() != ControlTypeInteger64) {
			cerr << "Control type mismatch after setting to int64_t array" << endl;
			return TestFail;
		}

		Span<const int64_t> int64sResult = value.get<Span<const int64_t>>();
		if (int64s.size() != int64sResult.size() ||
		    !std::equal(int64s.begin(), int64s.end(), int64sResult.begin())) {
			cerr << "Control value mismatch after setting to int64_t array" << endl;
			return TestFail;
		}

		if (value.toString() != "[ 3, 14, 15, 9 ]") {
			cerr << "Control string mismatch after setting to int64_t array" << endl;
			return TestFail;
		}

		/*
		 * Float type.
		 */
		value.set(-0.42f);
		if (value.isNone() || value.isArray() ||
		    value.type() != ControlTypeFloat) {
			cerr << "Control type mismatch after setting to float" << endl;
			return TestFail;
		}

		if (value.get<float>() != -0.42f) {
			cerr << "Control value mismatch after setting to float" << endl;
			return TestFail;
		}

		if (value.toString() != "-0.420000") {
			cerr << "Control string mismatch after setting to float" << endl;
			return TestFail;
		}

		std::array<float, 3> floats{ 3.141593, 2.718282, 299792458.0 };
		value.set(Span<float>(floats));
		if (value.isNone() || !value.isArray() ||
		    value.type() != ControlTypeFloat) {
			cerr << "Control type mismatch after setting to float array" << endl;
			return TestFail;
		}

		Span<const float> floatsResult = value.get<Span<const float>>();
		if (floats.size() != floatsResult.size() ||
		    !std::equal(floats.begin(), floats.end(), floatsResult.begin())) {
			cerr << "Control value mismatch after setting to float array" << endl;
			return TestFail;
		}

		/*
		 * The string representation for the third value doesn't match
		 * the value in the floats array above, due to limited precision
		 * of the float type that can't properly represent the speed of
		 * light.
		 */
		if (value.toString() != "[ 3.141593, 2.718282, 299792448.000000 ]") {
			cerr << "Control string mismatch after setting to float array" << endl;
			return TestFail;
		}

		/*
		 * String type.
		 */
		std::string string{ "libcamera" };
		value.set(string);
		if (value.isNone() || !value.isArray() ||
		    value.type() != ControlTypeString ||
		    value.numElements() != string.size()) {
			cerr << "Control type mismatch after setting to string" << endl;
			return TestFail;
		}

		if (value.get<std::string>() != string) {
			cerr << "Control value mismatch after setting to string" << endl;
			return TestFail;
		}

		if (value.toString() != string) {
			cerr << "Control string mismatch after setting to string" << endl;
			return TestFail;
		}

		return TestPass;
	}
};

TEST_REGISTER(ControlValueTest)
generated by cgit v1.2.1 (git 2.18.0) at 2025-01-06 14:00:43 +0000