summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDavid Plowman <david.plowman@raspberrypi.com>2020-12-01 17:55:34 +0000
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2020-12-01 20:44:16 +0200
commit472d3d3cdb04388b4ada7c7c4cee71fe1145b663 (patch)
tree0391bb6b84886e04d3fa26fc4e7c72956af695a1 /src
parent4db11b57258a1ea3a0e58f1e05d1854de0510d67 (diff)
src: ipa: raspberrypi: Improve behaviour when AE disabled
AE/AGC "disabled" is now handled better by the algorithm for itself, so it no longer needs to be "resumed" before setting fixed shutter or gain values. Signed-off-by: David Plowman <david.plowman@raspberrypi.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src')
-rw-r--r--src/ipa/raspberrypi/raspberrypi.cpp8
1 files changed, 0 insertions, 8 deletions
diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
index 9853a343..29d48b1b 100644
--- a/src/ipa/raspberrypi/raspberrypi.cpp
+++ b/src/ipa/raspberrypi/raspberrypi.cpp
@@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)
/* This expects units of micro-seconds. */
agc->SetFixedShutter(ctrl.second.get<int32_t>());
- /* For the manual values to take effect, AGC must be unpaused. */
- if (agc->IsPaused())
- agc->Resume();
-
libcameraMetadata_.set(controls::ExposureTime, ctrl.second.get<int32_t>());
break;
}
@@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)
ASSERT(agc);
agc->SetFixedAnalogueGain(ctrl.second.get<float>());
- /* For the manual values to take effect, AGC must be unpaused. */
- if (agc->IsPaused())
- agc->Resume();
-
libcameraMetadata_.set(controls::AnalogueGain,
ctrl.second.get<float>());
break;