summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo@jmondi.org>2021-01-02 11:35:32 +0100
committerJacopo Mondi <jacopo@jmondi.org>2021-01-25 14:54:04 +0100
commit021752924b1721db9aae656af6910b50fb78915f (patch)
tree6ce5ee2367fcb81dfe02b11be1155a3ae9a6889b /src
parentdb19dcb75d1d06dcdb0b9f8fe3de668aca6b8178 (diff)
libcamera: camera_sensor: Make V4L2_CID_EXPOSURE mandatory
Add the V4L2_CID_EXPOSURE control to the list of mandatory controls the sensor driver has to report and document this new requirement. While at it, re-sort the mandatory V4L2 controls in alphabetical order in the CameraSensor class and remove the above comment as the usage of the controls is better reported in the documentation. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Diffstat (limited to 'src')
-rw-r--r--src/libcamera/camera_sensor.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp
index 9abb9d33..ca33c009 100644
--- a/src/libcamera/camera_sensor.cpp
+++ b/src/libcamera/camera_sensor.cpp
@@ -239,12 +239,11 @@ int CameraSensor::validateSensorDriver()
/*
* Make sure the sensor driver supports the mandatory controls
* required by the CameraSensor class.
- * - V4L2_CID_PIXEL_RATE is used to calculate the sensor timings
- * - V4L2_CID_HBLANK is used to calculate the line length
*/
const std::vector<uint32_t> mandatoryControls{
- V4L2_CID_PIXEL_RATE,
+ V4L2_CID_EXPOSURE,
V4L2_CID_HBLANK,
+ V4L2_CID_PIXEL_RATE,
};
ControlList ctrls = subdev_->getControls(mandatoryControls);