libcamera/pinchartl/libcamera.git - Laurent Pinchart's clone of libcamera

summary refs log tree commit diff

path: root/src/ipa/libipa

diff options

author	Laurent Pinchart <laurent.pinchart@ideasonboard.com>	2021-01-31 19:35:44 +0200
committer	Laurent Pinchart <laurent.pinchart@ideasonboard.com>	2021-02-05 01:24:35 +0200
commit	79266225d2af742195f99be7c91c7d5356f7eb78 (patch)
tree	ec065a385d91150f163d132ad148e78c58693cca /src/ipa/libipa
parent	5e1f0d8b54ab27fdbf3dbc202af1b63bf4eb10da (diff)

libcamera: camera_sensor: Check control availability from idmap

The presence of mandatory and optional controls is checked in CameraSensor::validateSensorDriver() by trying to retrieve them. This causes an error message to be printed in the V4L2Device class if an optional control isn't present, while this isn't an error. To fix this, use the control idmap reported by the V4L2Device to check for controls availability. The function can now print the whole list of missing controls, making debugging easier. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Diffstat (limited to 'src/ipa/libipa')

0 files changed, 0 insertions, 0 deletions

">/* SPDX-License-Identifier: GPL-2.0-or-later */ /* * Copyright (C) 2019, Google Inc. * * main_window.h - qcam - Main application window */ #pragma once #include <memory> #include <vector> #include <libcamera/camera.h> #include <libcamera/camera_manager.h> #include <libcamera/controls.h> #include <libcamera/framebuffer.h> #include <libcamera/framebuffer_allocator.h> #include <libcamera/request.h> #include <libcamera/stream.h> #include <QElapsedTimer> #include <QIcon> #include <QMainWindow> #include <QMutex> #include <QObject> #include <QQueue> #include <QTimer> #include "../cam/stream_options.h" #include "viewfinder.h" class QAction; class QComboBox; class Image; class HotplugEvent; enum { OptCamera = 'c', OptHelp = 'h', OptRenderer = 'r', OptStream = 's', OptVerbose = 'v', }; class MainWindow : public QMainWindow { Q_OBJECT public: MainWindow(libcamera::CameraManager *cm, const OptionsParser::Options &options); ~MainWindow(); bool event(QEvent *e) override; private Q_SLOTS: void quit(); void updateTitle(); void switchCamera(int index); void toggleCapture(bool start); void saveImageAs(); void captureRaw(); void processRaw(libcamera::FrameBuffer *buffer, const libcamera::ControlList &metadata); void queueRequest(libcamera::FrameBuffer *buffer); private: int createToolbars(); std::string chooseCamera(); int openCamera(); int startCapture(); void stopCapture(); void addCamera(std::shared_ptr<libcamera::Camera> camera); void removeCamera(std::shared_ptr<libcamera::Camera> camera); void requestComplete(libcamera::Request *request); void processCapture(); void processHotplug(HotplugEvent *e); void processViewfinder(libcamera::FrameBuffer *buffer); /* UI elements */ QToolBar *toolbar_; QAction *startStopAction_; QComboBox *cameraCombo_; QAction *saveRaw_; ViewFinder *viewfinder_; QIcon iconPlay_; QIcon iconStop_; QString title_; QTimer titleTimer_; /* Options */ const OptionsParser::Options &options_; /* Camera manager, camera, configuration and buffers */ libcamera::CameraManager *cm_; std::shared_ptr<libcamera::Camera> camera_; libcamera::FrameBufferAllocator *allocator_; std::unique_ptr<libcamera::CameraConfiguration> config_; std::map<libcamera::FrameBuffer *, std::unique_ptr<Image>> mappedBuffers_; /* Capture state, buffers queue and statistics */ bool isCapturing_; bool captureRaw_; libcamera::Stream *vfStream_; libcamera::Stream *rawStream_; std::map<const libcamera::Stream *, QQueue<libcamera::FrameBuffer *>> freeBuffers_; QQueue<libcamera::Request *> doneQueue_; QQueue<libcamera::Request *> freeQueue_; QMutex mutex_; /* Protects freeBuffers_, doneQueue_, and freeQueue_ */ uint64_t lastBufferTime_; QElapsedTimer frameRateInterval_; uint32_t previousFrames_; uint32_t framesCaptured_; std::vector<std::unique_ptr<libcamera::Request>> requests_; };