summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-07-31 02:23:12 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2024-08-01 01:22:14 +0300
commita3ddf56a00c1cd7801c6e3c9a628618978377c9f (patch)
tree16e155d9834c0946d0e235994b4a3f04dfc1374d
parentefc7a85bc00a767427c219a43d0bb420dfc6361b (diff)
libcamera: software_isp: Remove file seal TODO item
The file seal TODO item has been addressed. Remove it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Tested-by: Milan Zamazal <mzamazal@redhat.com> Tested-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-rw-r--r--src/libcamera/software_isp/TODO19
1 files changed, 0 insertions, 19 deletions
diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO
index 6bdc5905..9978afc0 100644
--- a/src/libcamera/software_isp/TODO
+++ b/src/libcamera/software_isp/TODO
@@ -1,22 +1,3 @@
-1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()
-
->> SharedMem::SharedMem(const std::string &name, std::size_t size)
->> : name_(name), size_(size), mem_(nullptr)
->>
->> ...
->>
->> if (ftruncate(fd_.get(), size_) < 0)
->> return;
->
-> Should we set the GROW and SHRINK seals (in a separate patch) ?
-
-Yes, this can be done.
-Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch
-some potential errors related to improper access to the shared memory allocated by
-the SharedMemObject.
-
----
-
2. Reconsider stats sharing
>>> +void SwStatsCpu::finishFrame(void)