From a3ddf56a00c1cd7801c6e3c9a628618978377c9f Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Wed, 31 Jul 2024 02:23:12 +0300 Subject: libcamera: software_isp: Remove file seal TODO item The file seal TODO item has been addressed. Remove it. Signed-off-by: Laurent Pinchart Reviewed-by: Milan Zamazal Reviewed-by: Kieran Bingham Tested-by: Milan Zamazal Tested-by: Hans de Goede Reviewed-by: Hans de Goede --- src/libcamera/software_isp/TODO | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO index 6bdc5905..9978afc0 100644 --- a/src/libcamera/software_isp/TODO +++ b/src/libcamera/software_isp/TODO @@ -1,22 +1,3 @@ -1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate() - ->> SharedMem::SharedMem(const std::string &name, std::size_t size) ->> : name_(name), size_(size), mem_(nullptr) ->> ->> ... ->> ->> if (ftruncate(fd_.get(), size_) < 0) ->> return; -> -> Should we set the GROW and SHRINK seals (in a separate patch) ? - -Yes, this can be done. -Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch -some potential errors related to improper access to the shared memory allocated by -the SharedMemObject. - ---- - 2. Reconsider stats sharing >>> +void SwStatsCpu::finishFrame(void) -- cgit v1.2.1