1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
|
/* SPDX-License-Identifier: LGPL-2.1-or-later */
/*
* Copyright (C) 2021-2022, Ideas On Board
*
* filter.cpp - RkISP1 Filter control
*/
#include "filter.h"
#include <cmath>
#include <libcamera/base/log.h>
#include <libcamera/control_ids.h>
/**
* \file filter.h
*/
namespace libcamera {
namespace ipa::rkisp1::algorithms {
/**
* \class Filter
* \brief RkISP1 Filter control
*
* Denoise and Sharpness filters will be applied by RkISP1 during the
* demosaicing step. The denoise filter is responsible for removing noise from
* the image, while the sharpness filter will enhance its acutance.
*
* \todo In current version the denoise and sharpness control is based on user
* controls. In a future version it should be controlled automatically by the
* algorithm.
*/
LOG_DEFINE_CATEGORY(RkISP1Filter)
static constexpr uint32_t kFiltLumWeightDefault = 0x00022040;
static constexpr uint32_t kFiltModeDefault = 0x000004f2;
/**
* \copydoc libcamera::ipa::Algorithm::queueRequest
*/
void Filter::queueRequest(IPAContext &context,
[[maybe_unused]] const uint32_t frame,
IPAFrameContext &frameContext,
const ControlList &controls)
{
auto &filter = context.activeState.filter;
bool update = false;
const auto &sharpness = controls.get(controls::Sharpness);
if (sharpness) {
unsigned int value = std::round(std::clamp(*sharpness, 0.0f, 10.0f));
if (filter.sharpness != value) {
filter.sharpness = value;
update = true;
}
LOG(RkISP1Filter, Debug) << "Set sharpness to " << *sharpness;
}
const auto &denoise = controls.get(controls::draft::NoiseReductionMode);
if (denoise) {
LOG(RkISP1Filter, Debug) << "Set denoise to " << *denoise;
switch (*denoise) {
case controls::draft::NoiseReductionModeOff:
if (filter.denoise != 0) {
filter.denoise = 0;
update = true;
}
break;
case controls::draft::NoiseReductionModeMinimal:
if (filter.denoise != 1) {
filter.denoise = 1;
update = true;
}
break;
case controls::draft::NoiseReductionModeHighQuality:
case controls::draft::NoiseReductionModeFast:
if (filter.denoise != 3) {
filter.denoise = 3;
update = true;
}
break;
default:
LOG(RkISP1Filter, Error)
<< "Unsupported denoise value "
<< *denoise;
break;
}
}
frameContext.filter.denoise = filter.denoise;
frameContext.filter.sharpness = filter.sharpness;
frameContext.filter.update = update;
}
/**
* \copydoc libcamera::ipa::Algorithm::prepare
*/
void Filter::prepare([[maybe_unused]] IPAContext &context,
[[maybe_unused]] const uint32_t frame,
IPAFrameContext &frameContext, rkisp1_params_cfg *params)
{
/* Check if the algorithm configuration has been updated. */
if (!frameContext.filter.update)
return;
static constexpr uint16_t filt_fac_sh0[] = {
0x04, 0x07, 0x0a, 0x0c, 0x10, 0x14, 0x1a, 0x1e, 0x24, 0x2a, 0x30
};
static constexpr uint16_t filt_fac_sh1[] = {
0x04, 0x08, 0x0c, 0x10, 0x16, 0x1b, 0x20, 0x26, 0x2c, 0x30, 0x3f
};
static constexpr uint16_t filt_fac_mid[] = {
0x04, 0x06, 0x08, 0x0a, 0x0c, 0x10, 0x13, 0x17, 0x1d, 0x22, 0x28
};
static constexpr uint16_t filt_fac_bl0[] = {
0x02, 0x02, 0x04, 0x06, 0x08, 0x0a, 0x0c, 0x10, 0x15, 0x1a, 0x24
};
static constexpr uint16_t filt_fac_bl1[] = {
0x00, 0x00, 0x00, 0x02, 0x04, 0x04, 0x06, 0x08, 0x0d, 0x14, 0x20
};
static constexpr uint16_t filt_thresh_sh0[] = {
0, 18, 26, 36, 41, 75, 90, 120, 170, 250, 1023
};
static constexpr uint16_t filt_thresh_sh1[] = {
0, 33, 44, 51, 67, 100, 120, 150, 200, 300, 1023
};
static constexpr uint16_t filt_thresh_bl0[] = {
0, 8, 13, 23, 26, 50, 60, 80, 140, 180, 1023
};
static constexpr uint16_t filt_thresh_bl1[] = {
0, 2, 5, 10, 15, 20, 26, 51, 100, 150, 1023
};
static constexpr uint16_t stage1_select[] = {
6, 6, 4, 4, 3, 3, 2, 2, 2, 1, 0
};
static constexpr uint16_t filt_chr_v_mode[] = {
1, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3
};
static constexpr uint16_t filt_chr_h_mode[] = {
0, 3, 3, 3, 3, 3, 3, 3, 3, 3, 3
};
uint8_t denoise = frameContext.filter.denoise;
uint8_t sharpness = frameContext.filter.sharpness;
auto &flt_config = params->others.flt_config;
flt_config.fac_sh0 = filt_fac_sh0[sharpness];
flt_config.fac_sh1 = filt_fac_sh1[sharpness];
flt_config.fac_mid = filt_fac_mid[sharpness];
flt_config.fac_bl0 = filt_fac_bl0[sharpness];
flt_config.fac_bl1 = filt_fac_bl1[sharpness];
flt_config.lum_weight = kFiltLumWeightDefault;
flt_config.mode = kFiltModeDefault;
flt_config.thresh_sh0 = filt_thresh_sh0[denoise];
flt_config.thresh_sh1 = filt_thresh_sh1[denoise];
flt_config.thresh_bl0 = filt_thresh_bl0[denoise];
flt_config.thresh_bl1 = filt_thresh_bl1[denoise];
flt_config.grn_stage1 = stage1_select[denoise];
flt_config.chr_v_mode = filt_chr_v_mode[denoise];
flt_config.chr_h_mode = filt_chr_h_mode[denoise];
/*
* Combined high denoising and high sharpening requires some
* adjustments to the configuration of the filters. A first stage
* filter with a lower strength must be selected, and the blur factors
* must be decreased.
*/
if (denoise == 9) {
if (sharpness > 3)
flt_config.grn_stage1 = 2;
} else if (denoise == 10) {
if (sharpness > 5)
flt_config.grn_stage1 = 2;
else if (sharpness > 3)
flt_config.grn_stage1 = 1;
}
if (denoise > 7) {
if (sharpness > 7) {
flt_config.fac_bl0 /= 2;
flt_config.fac_bl1 /= 4;
} else if (sharpness > 4) {
flt_config.fac_bl0 = flt_config.fac_bl0 * 3 / 4;
flt_config.fac_bl1 /= 2;
}
}
params->module_en_update |= RKISP1_CIF_ISP_MODULE_FLT;
params->module_ens |= RKISP1_CIF_ISP_MODULE_FLT;
params->module_cfg_update |= RKISP1_CIF_ISP_MODULE_FLT;
}
REGISTER_IPA_ALGORITHM(Filter, "Filter")
} /* namespace ipa::rkisp1::algorithms */
} /* namespace libcamera */
|
