summaryrefslogtreecommitdiff
path: root/utils/codegen/ipc/mojo/public/tools
diff options
context:
space:
mode:
authorStefan Klug <stefan.klug@ideasonboard.com>2025-03-26 14:47:22 +0100
committerStefan Klug <stefan.klug@ideasonboard.com>2025-03-26 17:16:39 +0100
commit4adf0e0b1cf9733127591c24c2a6129fda481dd9 (patch)
tree919e1cbf23126a2609da4992a759f205b4ee3786 /utils/codegen/ipc/mojo/public/tools
parent03bae6b9248280a3edd9350061cc307d95ba1cd0 (diff)
ipa: rksip1: Remove setControls(0) to reduce startup oscillationsHEADmaster
The call to setControls(0) is counter productive. At start() time, no requests were queued and no stats were received. So setControls(0) accesses a zeroed frame context and in turn sends 0 as gain, exposure and vblank to the pipeline handler and DelayedControls. This leads to strong oscillations on every start of the camera. A proper fix for handling the startup controls still needs to be done and was already started in [1] and [2]. From a DelayedControls point of view the call to setControls(0) is also unnecessary as DelayedControls treat frame 0 as already being queued in after initialization. So it is safe to just remove it and the removal fixes the zero effectiveExposureValue discussed in the previous patch for rkisp1. [1]: https://patchwork.libcamera.org/patch/21708/ [2]: https://patchwork.libcamera.org/patch/22445/ Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'utils/codegen/ipc/mojo/public/tools')
0 files changed, 0 insertions, 0 deletions