summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-04-29 02:08:11 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2019-04-29 15:54:40 +0300
commitb771196d91245084784bf477f0e6aaf8642abffb (patch)
treee65fe9ce903daab3d721039db147d1245f5dc6ee /test
parent5caa8a971d3dc6bc1287c8c9dd932f6b64412cbc (diff)
libcamera: Don't ignore the return value of read() and write()
The glibc read() and write() functions are defined with the __warn_unused_result__ attribute when using FORTIFY_SOURCE. Don't ignore their return value. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'test')
-rw-r--r--test/event.cpp13
1 files changed, 11 insertions, 2 deletions
diff --git a/test/event.cpp b/test/event.cpp
index 52bc0c7e..9bd87615 100644
--- a/test/event.cpp
+++ b/test/event.cpp
@@ -38,6 +38,7 @@ protected:
EventDispatcher *dispatcher = CameraManager::instance()->eventDispatcher();
std::string data("H2G2");
Timer timeout;
+ ssize_t ret;
EventNotifier readNotifier(pipefd_[0], EventNotifier::Read);
readNotifier.activated.connect(this, &EventTest::readReady);
@@ -46,7 +47,11 @@ protected:
memset(data_, 0, sizeof(data_));
size_ = 0;
- write(pipefd_[1], data.data(), data.size());
+ ret = write(pipefd_[1], data.data(), data.size());
+ if (ret < 0) {
+ cout << "Pipe write failed" << endl;
+ return TestFail;
+ }
timeout.start(100);
dispatcher->processEvents();
@@ -73,7 +78,11 @@ protected:
notified_ = false;
readNotifier.setEnabled(false);
- write(pipefd_[1], data.data(), data.size());
+ ret = write(pipefd_[1], data.data(), data.size());
+ if (ret < 0) {
+ cout << "Pipe write failed" << endl;
+ return TestFail;
+ }
timeout.start(100);
dispatcher->processEvents();