diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2019-10-27 00:36:13 +0300 |
|---|---|---|
| committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2020-08-25 02:58:04 +0300 |
| commit | dbafe16da7a9999ec77da21a42537702fb87f124 (patch) | |
| tree | bf195d3f0feee0efc714267f70d85bfc54b8c63c /test/camera | |
| parent | 3ef378731ad89de4dd77e0cb79860cc86676060e (diff) | |
meson: Remove -Wno-unused-parameter
We build libcamera with -Wno-unused-parameter and this doesn't cause
much issue internally. However, it prevents catching unused parameters
in inline functions defined in public headers. This can lead to
compilation warnings for applications compiled without
-Wno-unused-parameter.
To catch those issues, remove -Wno-unused-parameter and fix all the
related warnings with [[maybe_unused]].
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Diffstat (limited to 'test/camera')
| -rw-r--r-- | test/camera/buffer_import.cpp | 3 | ||||
| -rw-r--r-- | test/camera/capture.cpp | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp index 97a85827..d57ffa75 100644 --- a/test/camera/buffer_import.cpp +++ b/test/camera/buffer_import.cpp @@ -33,7 +33,8 @@ public: } protected: - void bufferComplete(Request *request, FrameBuffer *buffer) + void bufferComplete([[maybe_unused]] Request *request, + FrameBuffer *buffer) { if (buffer->metadata().status != FrameMetadata::FrameSuccess) return; diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp index 0fe3bf9b..eb67bf2d 100644 --- a/test/camera/capture.cpp +++ b/test/camera/capture.cpp @@ -26,7 +26,8 @@ protected: unsigned int completeBuffersCount_; unsigned int completeRequestsCount_; - void bufferComplete(Request *request, FrameBuffer *buffer) + void bufferComplete([[maybe_unused]] Request *request, + FrameBuffer *buffer) { if (buffer->metadata().status != FrameMetadata::FrameSuccess) return; |