diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2019-08-18 03:24:56 +0300 |
|---|---|---|
| committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2019-08-19 19:07:45 +0300 |
| commit | 53704ac3f406a776cfe636c45fd7fdd305962788 (patch) | |
| tree | d097fbf758624f2ae23940f9156845ddc43bc749 /test/camera | |
| parent | 3e4672f159791c6334ee943c67a3273161256bcd (diff) | |
libcamera: camera_manager: Construct CameraManager instances manually
The CameraManager class is not supposed to be instantiated multiple
times, which led to a singleton implementation. This requires a global
instance of the CameraManager, which is destroyed when the global
destructors are executed.
Relying on global instances causes issues with cleanup, as the order in
which the global destructors are run can't be controlled. In particular,
the Android camera HAL implementation ends up destroying the
CameraHalManager after the CameraManager, which leads to use-after-free
problems.
To solve this, remove the CameraManager::instance() method and make the
CameraManager class instantiable directly. Multiple instances are still
not allowed, and this is enforced by storing the instance pointer
internally to be checked when an instance is created.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Diffstat (limited to 'test/camera')
| -rw-r--r-- | test/camera/camera_test.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/camera/camera_test.cpp b/test/camera/camera_test.cpp index 24ff5fe0..0e105414 100644 --- a/test/camera/camera_test.cpp +++ b/test/camera/camera_test.cpp @@ -14,7 +14,7 @@ using namespace std; int CameraTest::init() { - cm_ = CameraManager::instance(); + cm_ = new CameraManager(); if (cm_->start()) { cout << "Failed to start camera manager" << endl; @@ -44,4 +44,5 @@ void CameraTest::cleanup() } cm_->stop(); + delete cm_; }; |