summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorTomi Valkeinen <tomi.valkeinen@iki.fi>2020-10-22 11:17:29 +0300
committerKieran Bingham <kieran.bingham@ideasonboard.com>2020-10-27 14:48:17 +0000
commit7973efcbc03132facdd5dde91074277f63e1c151 (patch)
tree6bce09120a03ee00ad9e3e930a45212e94b8fc71 /src
parent22679a81ebf5a69ef28c52e01ae259d96b27072a (diff)
pipeline: raspberrypi: return an error if setFormat() fails
The method calls setFormat(), stores the return value, but then does not do anything with the return value. I presume it is meant to fail and return the error. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi> Reviewed-by: Naushir Patuck <naush@raspberrypi.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src')
-rw-r--r--src/libcamera/pipeline/raspberrypi/raspberrypi.cpp2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
index a48013d8..0a60442c 100644
--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
@@ -593,6 +593,8 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)
* because of flips in the sensor.
*/
ret = data->isp_[Isp::Input].dev()->setFormat(&sensorFormat);
+ if (ret)
+ return ret;
/*
* See which streams are requested, and route the user