summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorUmang Jain <umang.jain@ideasonboard.com>2022-04-08 15:51:45 +0530
committerUmang Jain <umang.jain@ideasonboard.com>2022-04-13 19:00:02 +0530
commit52cd4dacd0ee89a3785f661592d515537180fe64 (patch)
tree7eb54cf42b5a19a61c28a27ff391c36bbbdd0fbb /src
parent17240772255352079958d81939f5dffd4aae4224 (diff)
ipa: vimc: Establish logical order of operations
It is preferred that the interface definition should represent the logical order in which the operations will be called. The patch has no functional changes. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Diffstat (limited to 'src')
-rw-r--r--src/ipa/vimc/vimc.cpp12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp
index 315302c6..a62e72b0 100644
--- a/src/ipa/vimc/vimc.cpp
+++ b/src/ipa/vimc/vimc.cpp
@@ -43,8 +43,8 @@ public:
void mapBuffers(const std::vector<IPABuffer> &buffers) override;
void unmapBuffers(const std::vector<unsigned int> &ids) override;
- void fillParams(uint32_t frame, uint32_t bufferId) override;
void queueRequest(uint32_t frame, const ControlList &controls) override;
+ void fillParams(uint32_t frame, uint32_t bufferId) override;
private:
void initTrace();
@@ -129,6 +129,11 @@ void IPAVimc::unmapBuffers(const std::vector<unsigned int> &ids)
}
}
+void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,
+ [[maybe_unused]] const ControlList &controls)
+{
+}
+
void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)
{
auto it = buffers_.find(bufferId);
@@ -140,11 +145,6 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)
paramsFilled.emit(bufferId);
}
-void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,
- [[maybe_unused]] const ControlList &controls)
-{
-}
-
void IPAVimc::initTrace()
{
struct stat fifoStat;