summaryrefslogtreecommitdiff
path: root/src/v4l2
diff options
context:
space:
mode:
authorBarnabás Pőcze <barnabas.pocze@ideasonboard.com>2025-01-28 12:40:56 +0100
committerBarnabás Pőcze <barnabas.pocze@ideasonboard.com>2025-04-01 16:13:00 +0200
commit799982b6465a9389bf525b91dbb100e6dd1913c9 (patch)
tree150d722319a6309f8263419d79ee5bac1bda629e /src/v4l2
parent5646307b71dbfeb3864788c8a57957c594a45975 (diff)
libcamera: pipeline: uvcvideo: Fix `ExposureTimeMode` control setup
`ControlInfo(Span<const int32_t>{...})` calls the incorrect constructor of `ControlInfo`. The intended constructor to be called is `ControlInfo(Span<const ControlValue>, ...)` however that is not called because a span of `const int32_t` is passed. Instead, the constructor `ControlInfo(const ControlValue &min, const ControlValue &max, ...)` will be called. Furthermore, since `values.back()` is used, only the last element of the array is actually set. To fix this, convert the array to contain `ControlValue` objects and use a separate variable to keep track of which element to set next. For each of `ExposureTimeMode{Auto,Manual}` save the V4L2 control value that is to be used when the libcamera control is set. Fixes: bad8d591f8acfa ("libcamera: uvcvideo: Register ExposureTimeMode control") Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Diffstat (limited to 'src/v4l2')
0 files changed, 0 insertions, 0 deletions