summaryrefslogtreecommitdiff
path: root/src/libcamera/stream.cpp
diff options
context:
space:
mode:
authorNiklas Söderlund <niklas.soderlund@ragnatech.se>2019-11-26 00:04:53 +0100
committerNiklas Söderlund <niklas.soderlund@ragnatech.se>2020-01-12 16:10:37 +0100
commitae9a05847cead7ddedba0ae150e538562afbb13f (patch)
tree0a73fab59990c825235e31075676717dfede16d5 /src/libcamera/stream.cpp
parent007517618c8440d09cfd39db5dbf451e87ef703a (diff)
libcamera: buffer: Switch from Plane to FrameBuffer::Plane
It is not libcamera's responsibility to handle memory mappings. Switch from the soon to be removed Plane class which deals with memory mappings to FrameBuffer::Plane which just describes it. This makes the transition to the full FrameBuffer easier. As the full FrameBuffer interface has not yet spread to all parts of libcamera core it is hard to create efficient caching of memory mappings in the qcam application. This will be fixed in a later patch, for now the dmabuf is mapped and unmapped each time it is seen by the application. Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src/libcamera/stream.cpp')
-rw-r--r--src/libcamera/stream.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp
index 45f31ae1..16a323f1 100644
--- a/src/libcamera/stream.cpp
+++ b/src/libcamera/stream.cpp
@@ -577,8 +577,10 @@ int Stream::mapBuffer(const Buffer *buffer)
if (dmabufs[i] == -1)
break;
- mem->planes().emplace_back();
- mem->planes().back().setDmabuf(dmabufs[i], 0);
+ FrameBuffer::Plane plane;
+ plane.fd = FileDescriptor(dmabufs[i]);
+ plane.length = 0;
+ mem->planes().push_back(plane);
}
/* Remove the buffer from the cache and return its index. */