diff options
| author | Niklas Söderlund <niklas.soderlund@ragnatech.se> | 2019-11-22 17:31:08 +0100 |
|---|---|---|
| committer | Niklas Söderlund <niklas.soderlund@ragnatech.se> | 2020-01-12 16:10:37 +0100 |
| commit | dea689e1f260b904697a9c2f3d05b7b5068d85e1 (patch) | |
| tree | 3f4af3e375e64a7e54c4a044e0620679f7fe1032 /src/libcamera/request.cpp | |
| parent | 13724144f9bfd22f79d56431061bc55a887c1d10 (diff) | |
libcamera: request: In addBuffer() do not fetch stream from Buffer
In the FrameBuffer interface the stream will not be available from the
buffer object as the buffer might be allocated externally. The
application needs to explicitly state which stream the buffer is being
added for to the request.
Extend the addBuffer() function to get this information explicitly from
the caller.
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src/libcamera/request.cpp')
| -rw-r--r-- | src/libcamera/request.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 92330c1a..54dfb461 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -113,6 +113,7 @@ Request::~Request() /** * \brief Store a Buffer with its associated Stream in the Request + * \param[in] stream The stream the buffer belongs to * \param[in] buffer The Buffer to store in the request * * Ownership of the buffer is passed to the request. It will be deleted when @@ -125,9 +126,8 @@ Request::~Request() * \retval -EEXIST The request already contains a buffer for the stream * \retval -EINVAL The buffer does not reference a valid Stream */ -int Request::addBuffer(std::unique_ptr<Buffer> buffer) +int Request::addBuffer(Stream *stream, std::unique_ptr<Buffer> buffer) { - Stream *stream = buffer->stream(); if (!stream) { LOG(Request, Error) << "Invalid stream reference"; return -EINVAL; |