diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2021-07-23 04:39:44 +0300 |
|---|---|---|
| committer | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2021-08-17 00:24:16 +0300 |
| commit | cb63fc75fb27e5704020f6f5760aa8c4db728c6f (patch) | |
| tree | a7c99955c03f48f6c4677fff8972f51fa490fa3c /src/libcamera/pipeline/simple | |
| parent | 034b5d36992cbb345edbc7e9f7219d1093cbcf00 (diff) | |
libcamera: pipeline: Cast to derived pipeline handler with helpers
Replace manual static casts from the PipelineHandler pointer to a
derived class pointer with helper functions in the camera data classes.
This simplifies code accessing the pipeline from the camera data.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/libcamera/pipeline/simple')
| -rw-r--r-- | src/libcamera/pipeline/simple/simple.cpp | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index ef7687ea..8ff95472 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -155,6 +155,7 @@ public: MediaEntity *sensor); bool isValid() const { return sensor_ != nullptr; } + SimplePipelineHandler *pipe(); int init(); int setupLinks(); @@ -352,11 +353,14 @@ SimpleCameraData::SimpleCameraData(SimplePipelineHandler *pipe, [](const Entity &e) { return e.entity->name(); }); } +SimplePipelineHandler *SimpleCameraData::pipe() +{ + return static_cast<SimplePipelineHandler *>(Camera::Private::pipe()); +} + int SimpleCameraData::init() { - SimplePipelineHandler *pipe = - static_cast<SimplePipelineHandler *>(this->pipe()); - SimpleConverter *converter = pipe->converter(); + SimpleConverter *converter = pipe()->converter(); int ret; /* @@ -480,8 +484,7 @@ int SimpleCameraData::setupLinks() int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format, V4L2Subdevice::Whence whence) { - SimplePipelineHandler *pipe = - static_cast<SimplePipelineHandler *>(this->pipe()); + SimplePipelineHandler *pipe = SimpleCameraData::pipe(); int ret; /* @@ -582,8 +585,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() } /* Adjust the requested streams. */ - SimplePipelineHandler *pipe = static_cast<SimplePipelineHandler *>(data_->pipe()); - SimpleConverter *converter = pipe->converter(); + SimpleConverter *converter = data_->pipe()->converter(); /* * Enable usage of the converter when producing multiple streams, as |