libcamera: pipeline: simple: converter: Replace open() with isValid()

Simplify the SimpleConverter interface by opening the M2M device in the
constructor. The explicit call to open() is replaced by a check through
a new isValid() function, and the unused close() function is removed.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Phi-Bang Nguyen <pnguyen@baylibre.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
index 4a1f2052..9ad3aa62 100644
--- a/src/libcamera/pipeline/simple/simple.cpp
+++ b/src/libcamera/pipeline/simple/simple.cpp
@@ -763,9 +763,9 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)
 	/* Open the converter, if any. */
 	if (converter) {
 		converter_ = std::make_unique<SimpleConverter>(converter);
-		if (converter_->open() < 0) {
+		if (!converter_->isValid()) {
 			LOG(SimplePipeline, Warning)
-				<< "Failed to open converter, disabling format conversion";
+				<< "Failed to create converter, disabling format conversion";
 			converter_.reset();
 		} else {
 			converter_->bufferReady.connect(this, &SimplePipelineHandler::converterDone);