diff options
| author | Stefan Klug <stefan.klug@ideasonboard.com> | 2025-04-03 17:49:18 +0200 |
|---|---|---|
| committer | Stefan Klug <stefan.klug@ideasonboard.com> | 2025-05-20 11:20:08 +0200 |
| commit | c699d26573ebc3a6275d697a9032aedd9d19f974 (patch) | |
| tree | df7c5d0588cbbcc212318f32d5d9784a883bc040 /src/ipa/libipa/awb.h | |
| parent | 66e9604684ebc09ee848ecf7738beb329bd40c22 (diff) | |
libipa: awb: Make result of gainsFromColourTemp optional
In the grey world AWB case, if no colour gains are contained in the
tuning file, the colour gains get reset to 1 when the colour temperature
is set manually. This is unexpected and undesirable. Allow the
gainsFromColourTemp() function to return a std::nullopt to handle that
case.
While at it, remove an unnecessary import from rkisp1/algorithms/awb.h.
Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Diffstat (limited to 'src/ipa/libipa/awb.h')
| -rw-r--r-- | src/ipa/libipa/awb.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/ipa/libipa/awb.h b/src/ipa/libipa/awb.h index 4bab7a45..f4a86038 100644 --- a/src/ipa/libipa/awb.h +++ b/src/ipa/libipa/awb.h @@ -8,6 +8,7 @@ #pragma once #include <map> +#include <optional> #include <libcamera/control_ids.h> #include <libcamera/controls.h> @@ -39,7 +40,7 @@ public: virtual int init(const YamlObject &tuningData) = 0; virtual AwbResult calculateAwb(const AwbStats &stats, unsigned int lux) = 0; - virtual RGB<double> gainsFromColourTemperature(double colourTemperature) = 0; + virtual std::optional<RGB<double>> gainsFromColourTemperature(double colourTemperature) = 0; const ControlInfoMap::Map &controls() const { |