diff options
author | Kieran Bingham <kieran.bingham@ideasonboard.com> | 2023-07-05 00:22:48 +0100 |
---|---|---|
committer | Kieran Bingham <kieran.bingham@ideasonboard.com> | 2023-07-11 15:19:13 +0100 |
commit | f7a9f141569115a3da9edb758e3a5adbe723c330 (patch) | |
tree | 30349896cf96c25a08880c208626c2a7f1d9d057 /src/apps/qcam/main_window.cpp | |
parent | 22cc8bc25dae4b1457c852a7fb633526672d7032 (diff) |
v4l2: v4l2_camera_proxy: Prevent ioctl sign-extensions
Handling ioctl's within applications is often wrapped with a helper such
as xioctl. Unfortunately, there are many instances of xioctl which
incorrectly handle the correct size of the ioctl request.
This leads to incorrect sign-extension of ioctl's which have bit-31 set,
and can cause values to be passed into the libcamera's v4l2 adaptation
layer which no longer represent the true IOCTL code.
Match the implementation of the Linux kernel and ensure that only 32
bits of the ioctl request are used by assigning to an unsigned int.
Link: https://github.com/Motion-Project/motion/discussions/1636
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/apps/qcam/main_window.cpp')
0 files changed, 0 insertions, 0 deletions