diff options
| author | Nícolas F. R. A. Prado <nfraprado@collabora.com> | 2025-04-28 11:02:38 +0200 |
|---|---|---|
| committer | Paul Elder <paul.elder@ideasonboard.com> | 2025-05-13 20:17:19 +0200 |
| commit | f3a12332f6d987b34893b2a41294dba6db5feb39 (patch) | |
| tree | 4d65e78290230f622e6ed9870e31245dcbd93922 /src/apps/lc-compliance/tests/capture_test.cpp | |
| parent | d01342f1dc0e73c04526dfcb047d48227dde8e17 (diff) | |
Different base classes can be used for different setups on tests, but
all of them will need to setup the camera for the test. To reuse that
code, move it to a separate CameraHolder class that is inherited by test
classes.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
Diffstat (limited to 'src/apps/lc-compliance/tests/capture_test.cpp')
| -rw-r--r-- | src/apps/lc-compliance/tests/capture_test.cpp | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/src/apps/lc-compliance/tests/capture_test.cpp b/src/apps/lc-compliance/tests/capture_test.cpp index d02caa8a..29d8b7f8 100644 --- a/src/apps/lc-compliance/tests/capture_test.cpp +++ b/src/apps/lc-compliance/tests/capture_test.cpp @@ -15,13 +15,13 @@ #include <gtest/gtest.h> -#include "environment.h" +#include "test_base.h" namespace { using namespace libcamera; -class SimpleCapture : public testing::TestWithParam<std::tuple<std::vector<StreamRole>, int>> +class SimpleCapture : public testing::TestWithParam<std::tuple<std::vector<StreamRole>, int>>, public CameraHolder { public: static std::string nameParameters(const testing::TestParamInfo<SimpleCapture::ParamType> &info); @@ -29,8 +29,6 @@ public: protected: void SetUp() override; void TearDown() override; - - std::shared_ptr<Camera> camera_; }; /* @@ -39,20 +37,12 @@ protected: */ void SimpleCapture::SetUp() { - Environment *env = Environment::get(); - - camera_ = env->cm()->get(env->cameraId()); - - ASSERT_EQ(camera_->acquire(), 0); + acquireCamera(); } void SimpleCapture::TearDown() { - if (!camera_) - return; - - camera_->release(); - camera_.reset(); + releaseCamera(); } std::string SimpleCapture::nameParameters(const testing::TestParamInfo<SimpleCapture::ParamType> &info) |