diff options
| author | Hirokazu Honda <hiroh@chromium.org> | 2020-10-21 10:39:52 +0900 |
|---|---|---|
| committer | Kieran Bingham <kieran.bingham@ideasonboard.com> | 2020-10-21 11:18:12 +0100 |
| commit | b8dd5ce944eca4d17df585bb059595729905f7ec (patch) | |
| tree | f97c18dceae02825949738285b2115abe69e3b8a /src/android/post_processor.h | |
| parent | 88919c1e17b4d1bd8c3328899f533424f2cd9181 (diff) | |
android: Modify PostProcessor interface
In PostProcessor::process(), the |source| argument doesn't have
to be a pointer. This replaces its type, const pointer, with
const reference as the latter is preferred to the former.
libcamera::Span is cheap to construct/copy/move. We should deal
with the type as pass-by-value parameter. Therefore this also
drops the const reference in the |destination| argument.
Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Umang Jain <email@uajain.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'src/android/post_processor.h')
| -rw-r--r-- | src/android/post_processor.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/android/post_processor.h b/src/android/post_processor.h index a891c43a..5f87a5d1 100644 --- a/src/android/post_processor.h +++ b/src/android/post_processor.h @@ -20,8 +20,8 @@ public: virtual int configure(const libcamera::StreamConfiguration &inCfg, const libcamera::StreamConfiguration &outCfg) = 0; - virtual int process(const libcamera::FrameBuffer *source, - const libcamera::Span<uint8_t> &destination, + virtual int process(const libcamera::FrameBuffer &source, + libcamera::Span<uint8_t> destination, CameraMetadata *metadata) = 0; }; |