summaryrefslogtreecommitdiff
path: root/src/android/camera_worker.h
diff options
context:
space:
mode:
authorHirokazu Honda <hiroh@chromium.org>2021-04-03 22:57:34 +0900
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-04-20 05:59:08 +0300
commitd40430116b1b65d8deeeeea106368e20d8534a03 (patch)
tree02e20a38f4307f7f701b7d6ead58fa168f238937 /src/android/camera_worker.h
parent0b661d70ec62d69ffd4ea7bb0aeb92d7ad12b8d3 (diff)
android: CameraDevice: Fix Camera3RequestDescriptor leakage
CameraDevice creates Camera3RequestDescriptor in processCaptureRequest() and disallocates in requestComplete(). Camera3RequestDescriptor can never be destroyed if requestComplete() is never called. This avoid the memory leakage by storing them in map CameraRequestDescriptor. Signed-off-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'src/android/camera_worker.h')
-rw-r--r--src/android/camera_worker.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/android/camera_worker.h b/src/android/camera_worker.h
index d7060576..64b1658b 100644
--- a/src/android/camera_worker.h
+++ b/src/android/camera_worker.h
@@ -22,7 +22,7 @@ class CameraDevice;
class CaptureRequest
{
public:
- CaptureRequest(libcamera::Camera *camera, uint64_t cookie);
+ CaptureRequest(libcamera::Camera *camera);
const std::vector<int> &fences() const { return acquireFences_; }
libcamera::ControlList &controls() { return request_->controls(); }