summaryrefslogtreecommitdiff
path: root/src/android/camera_request.h
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-10-19 17:17:52 +0530
committerUmang Jain <umang.jain@ideasonboard.com>2021-10-19 19:14:58 +0530
commit030c8f1a7ea5e58e2a155b2fda19c6a72ccb310f (patch)
treed6dea37348161909501313156979e4a1c4044fcc /src/android/camera_request.h
parent109a98e8c07b57a4676bf62dbba59cba670163c8 (diff)
android: camera_request: Turn struct into a class
The Camera3RequestDescriptor structure is growing into an object with member functions. Turn it into a class, uninline the destructor to reduce code size, explicitly disable copy as requests are not copyable, and delete the default constructor to force all instances to be fully constructed. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Diffstat (limited to 'src/android/camera_request.h')
-rw-r--r--src/android/camera_request.h13
1 files changed, 9 insertions, 4 deletions
diff --git a/src/android/camera_request.h b/src/android/camera_request.h
index 1346f6fa..79dfdb58 100644
--- a/src/android/camera_request.h
+++ b/src/android/camera_request.h
@@ -10,6 +10,8 @@
#include <memory>
#include <vector>
+#include <libcamera/base/class.h>
+
#include <libcamera/camera.h>
#include <libcamera/framebuffer.h>
@@ -18,18 +20,18 @@
#include "camera_metadata.h"
#include "camera_worker.h"
-struct Camera3RequestDescriptor {
+class Camera3RequestDescriptor
+{
+public:
enum class Status {
Pending,
Success,
Error,
};
- Camera3RequestDescriptor() = default;
- ~Camera3RequestDescriptor() = default;
Camera3RequestDescriptor(libcamera::Camera *camera,
const camera3_capture_request_t *camera3Request);
- Camera3RequestDescriptor &operator=(Camera3RequestDescriptor &&) = default;
+ ~Camera3RequestDescriptor();
bool isPending() const { return status_ == Status::Pending; }
@@ -41,6 +43,9 @@ struct Camera3RequestDescriptor {
camera3_capture_result_t captureResult_ = {};
Status status_ = Status::Pending;
+
+private:
+ LIBCAMERA_DISABLE_COPY(Camera3RequestDescriptor)
};
#endif /* __ANDROID_CAMERA_REQUEST_H__ */