summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorBarnabás Pőcze <barnabas.pocze@ideasonboard.com>2025-02-24 10:38:00 +0100
committerBarnabás Pőcze <barnabas.pocze@ideasonboard.com>2025-03-21 14:46:44 +0100
commit4a5ad4e9b04e0c41efddc9800d4462c23c016904 (patch)
tree2151ab7f7b452842ad8ac205dd0e486eee737470 /include
parent330cd1c56007252932a100c741548b94131e09c6 (diff)
libcamera: media_object: Fix unnecessary copy
`MediaEntity::ancillaryEntities()` can just return a const lvalue reference to the underlying array, a copy need not be made. That was likely the original intention. Fixes: 9490c664b57a6c ("libcamera: Add members to MediaEntity to support ancillary entities") Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'include')
-rw-r--r--include/libcamera/internal/media_object.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h
index 9356d204..54e2e5ce 100644
--- a/include/libcamera/internal/media_object.h
+++ b/include/libcamera/internal/media_object.h
@@ -112,7 +112,7 @@ public:
unsigned int deviceMinor() const { return minor_; }
const std::vector<MediaPad *> &pads() const { return pads_; }
- const std::vector<MediaEntity *> ancillaryEntities() const { return ancillaryEntities_; }
+ const std::vector<MediaEntity *> &ancillaryEntities() const { return ancillaryEntities_; }
const MediaPad *getPadByIndex(unsigned int index) const;
const MediaPad *getPadById(unsigned int id) const;