summaryrefslogtreecommitdiff
path: root/include/libcamera/camera_manager.h
diff options
context:
space:
mode:
authorJacopo Mondi <jacopo@jmondi.org>2021-04-18 16:42:17 +0200
committerJacopo Mondi <jacopo@jmondi.org>2021-04-21 09:52:34 +0200
commit1fca6228fece89c9270ff1abb293fdf48f1b577b (patch)
treecd1aeaa7cf980d0703bbd16ce969a48b2586f751 /include/libcamera/camera_manager.h
parentd40430116b1b65d8deeeeea106368e20d8534a03 (diff)
libcamera: Drop argument from LIBCAMERA_DECLARE_PRIVATE
The LIBCAMERA_DECLARE_PRIVATE() macro, used by the library classes that inherit from libcamera::Extensible in order to implement the PIMPL pattern, expands to: public: \ class Private; \ friend class Private; The 'klass' argument is not used and it might confuse developers as it might hint that the class that defines the pattern's implementation can be freely named, while it is actually hardcoded to 'Private'. Drop the argument from the macro definition. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se> Reviewed-by: Hanlin Chen <hanlinchen@google.com> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Diffstat (limited to 'include/libcamera/camera_manager.h')
-rw-r--r--include/libcamera/camera_manager.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/libcamera/camera_manager.h b/include/libcamera/camera_manager.h
index 35a59f0d..c2f0b786 100644
--- a/include/libcamera/camera_manager.h
+++ b/include/libcamera/camera_manager.h
@@ -22,7 +22,7 @@ class Camera;
class CameraManager : public Object, public Extensible
{
- LIBCAMERA_DECLARE_PRIVATE(CameraManager)
+ LIBCAMERA_DECLARE_PRIVATE()
public:
CameraManager();
~CameraManager();