diff options
| author | Niklas Söderlund <niklas.soderlund@ragnatech.se> | 2019-11-26 00:04:53 +0100 |
|---|---|---|
| committer | Niklas Söderlund <niklas.soderlund@ragnatech.se> | 2020-01-12 16:10:37 +0100 |
| commit | ae9a05847cead7ddedba0ae150e538562afbb13f (patch) | |
| tree | 0a73fab59990c825235e31075676717dfede16d5 /include/libcamera/buffer.h | |
| parent | 007517618c8440d09cfd39db5dbf451e87ef703a (diff) | |
libcamera: buffer: Switch from Plane to FrameBuffer::Plane
It is not libcamera's responsibility to handle memory mappings. Switch
from the soon to be removed Plane class which deals with memory
mappings to FrameBuffer::Plane which just describes it. This makes the
transition to the full FrameBuffer easier.
As the full FrameBuffer interface has not yet spread to all parts of
libcamera core it is hard to create efficient caching of memory mappings
in the qcam application. This will be fixed in a later patch, for now
the dmabuf is mapped and unmapped each time it is seen by the
application.
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Diffstat (limited to 'include/libcamera/buffer.h')
| -rw-r--r-- | include/libcamera/buffer.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h index e66e9c9c..d61efad1 100644 --- a/include/libcamera/buffer.h +++ b/include/libcamera/buffer.h @@ -95,11 +95,11 @@ private: class BufferMemory final { public: - const std::vector<Plane> &planes() const { return planes_; } - std::vector<Plane> &planes() { return planes_; } + const std::vector<FrameBuffer::Plane> &planes() const { return planes_; } + std::vector<FrameBuffer::Plane> &planes() { return planes_; } private: - std::vector<Plane> planes_; + std::vector<FrameBuffer::Plane> planes_; }; class BufferPool final |