summaryrefslogtreecommitdiff
path: root/include/android
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-05-23 02:51:32 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2021-06-15 12:46:39 +0300
commit01e387acb0cc345fc9992498898efd167bf07b71 (patch)
tree5a2d7bd262495e47471fdd1d663e63789b4f4e3f /include/android
parent2f6b951b7561e6e725796b1d64a481ae306f3664 (diff)
libcamera: log: Destroy LogCategory instances in a controlled way
The LogCategory instances are constructed on first use as static variables in accessor functions, following the Meyers singleton pattern. As a result, their destruction order is not guaranteed. This can cause issues as the global Logger object, constructed in a similar fashion, is accessed from the LogCategory destructor and may be destroyed first. To fix this, keep the same singleton pattern, but allocate the LogCategory instances dynamically. As they get registered with the global Logger instance, we can destroy them in the Logger destructor. This only avoids destruction order issues between LogCategory and Logger, and doesn't address yet the fact that LOG() calls from destructors of global objects may access an already destroyed Logger. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Hirokazu Honda <hiroh@chormium.org> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Diffstat (limited to 'include/android')
0 files changed, 0 insertions, 0 deletions